-
Notifications
You must be signed in to change notification settings - Fork 229
Improve example for Polar projection #2110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/format |
I added |
…de review) Co-authored-by: Dongdong Tian <[email protected]>
I think this PR is in great and "WIP" can be removed from the title. @yvonnefroehlich What do you think? |
Co-authored-by: Dongdong Tian <[email protected]>
I am not totally sure. I understand the comment by @maxrjones in the way that descriptive titles should be added for the single subplots. Until now, I only wrote the positions. But maybe these are enough, as there are already quite detailed comments and titles would at least partly repeat the comments? |
Co-authored-by: Dongdong Tian <[email protected]>
Description of proposed changes
Correspoinding to #2058 (review) and #2058 (comment) this PR aims to improve the example for the Polar projection.
#--------------
)-t
modifier offrame
parameter (instead ofpygmt.Figure.text
method)Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.Slash Commands
You can write slash commands (
/command
) in the first line of a comment to performspecific operations. Supported slash commands are:
/format
: automatically format and lint the code/test-gmt-dev
: run full tests on the latest GMT development version