Skip to content

Improve gallery example "meca.py" #2199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 21, 2022
Merged

Improve gallery example "meca.py" #2199

merged 6 commits into from
Nov 21, 2022

Conversation

yvonnefroehlich
Copy link
Member

Description of proposed changes

This PR contains some improvement of the gallery example Focal mechanisms.
Now, the parameter word spec is explicitly used in the code, as this parameter name is explained in the text at the beginning.

I feel, it would be good to have a more detailed example or tutorial on plotting focal mechanisms. (See also the several posts/questions on the GMT forum).

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@yvonnefroehlich yvonnefroehlich added documentation Improvements or additions to documentation skip-changelog Skip adding Pull Request to changelog labels Nov 20, 2022
@yvonnefroehlich yvonnefroehlich added this to the 0.8.0 milestone Nov 20, 2022
@yvonnefroehlich yvonnefroehlich changed the title WIP: Improve gallery example "meca.py" Improve gallery example "meca.py" Nov 21, 2022
@seisman seisman merged commit cc532f1 into main Nov 21, 2022
@seisman seisman deleted the improve-examp-meca-01 branch November 21, 2022 15:20
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants