-
Notifications
You must be signed in to change notification settings - Fork 228
WIP: CI: Use iterative/setup-dvc to install dvc #2465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Regarding the title, are more changes expected on this PR? |
Probably need to consider if we want to accept a slower Windows build. |
My preference is to prioritize functionality (in this case executing the tests completely) over speed. If pinning |
The |
Nice! Seems like their release frequency is pretty high, so we may be able to wait. Though it would be best to have the tests passing before our release. |
I think we should pin funcy temporarily to make the tests pass So we can have the0.9.0 release done. |
Did you want to keep this |
Closing this PR. |
Description of proposed changes
dvc has a complicated dependency and sometimes dvc fails to work due to incompatible changes of other packges (e.g., #1693, #1543, #2338, and recent #2464 (comment)).
In this PR, I tried to use the
iterative/setup-dvc
action to install dvc instead of manually installingdvc
using mamba. It turns out theiterative/setup-dvc
action provides a more stable dvc installation. However,iteractive/setup-dvc
is extremely slow on Windows (takes about 2.5 minutes).Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.Slash Commands
You can write slash commands (
/command
) in the first line of a comment to performspecific operations. Supported slash commands are:
/format
: automatically format and lint the code/test-gmt-dev
: run full tests on the latest GMT development version