Skip to content

Temporarily pin funcy<2.0 for dvc fix #2468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 30, 2023
Merged

Temporarily pin funcy<2.0 for dvc fix #2468

merged 3 commits into from
Mar 30, 2023

Conversation

maxrjones
Copy link
Member

Description of proposed changes

This PR applies the suggestion from #2464 (comment) to pin funcy in order to fix the dvc issue in the test workflows.

Fixes #

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@maxrjones maxrjones added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Mar 30, 2023
@weiji14
Copy link
Member

weiji14 commented Mar 30, 2023

Hmm, both Windows tests are failing. Is there anything particular with the syntax of 'funcy<2.0' on Windows?


Run mamba install gmt=6.4.0 numpy=1.24 \
  mamba install gmt=6.4.0 numpy=1.24 \
                pandas xarray netCDF4 packaging \
                contextily geopandas ipython rioxarray \
                build dvc 'funcy<2.0' make 'pytest>=6.0' \
                pytest-cov pytest-doctestplus pytest-mpl sphinx-gallery
  shell: C:\Program Files\Git\bin\bash.EXE -l {0}
  env:
    OS: windows-latest
    PYTHON: 3.11
    NUMPY: 1.24
    INPUT_RUN_POST: false
    CONDA: C:\Miniconda3
    CONDA_PKGS_DIR: C:\Users\runneradmin\conda_pkgs_dir
bash: line 1: 2.0: No such file or directory
Error: Process completed with exit code 1.

@seisman
Copy link
Member

seisman commented Mar 30, 2023

Maybe we should pin funny to 1.8

@maxrjones
Copy link
Member Author

Maybe we should pin funny to 1.8

The versioning on conda-forge was a bit weird, but the last no-arch version was 1.18 which corresponds to the prior github release tag.

@seisman seisman added this to the 0.9.0 milestone Mar 30, 2023
@seisman seisman merged commit 26f8a51 into main Mar 30, 2023
@seisman seisman deleted the pin-funcy branch March 30, 2023 02:10
seisman added a commit that referenced this pull request Mar 30, 2023
@seisman seisman mentioned this pull request Mar 30, 2023
7 tasks
weiji14 pushed a commit that referenced this pull request Apr 2, 2023
Revert "Temporarily pin funcy<2.0 for dvc fix (#2468)"

This reverts commit 26f8a51.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants