Skip to content

Highlight arguments for "style" attribute of "pen" parameter in Gallery example "Line styles" #2520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

yvonnefroehlich
Copy link
Member

@yvonnefroehlich yvonnefroehlich commented Apr 25, 2023

Description of proposed changes

This PR adds highlighting for the arguments allowed for the style attribute of the pen parameter in the Gallery example Line styles.

Preview: https://pygmt-dev--2520.org.readthedocs.build/en/2520/gallery/lines/linestyles.html

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@yvonnefroehlich yvonnefroehlich added documentation Improvements or additions to documentation skip-changelog Skip adding Pull Request to changelog labels Apr 25, 2023
@yvonnefroehlich yvonnefroehlich added this to the 0.10.0 milestone Apr 25, 2023
@yvonnefroehlich yvonnefroehlich self-assigned this Apr 25, 2023
@yvonnefroehlich yvonnefroehlich changed the title Highlight arguments for "style" attribute of "pen" parameter in Highlight arguments for "style" attribute of "pen" parameter in Gallery example "Line styles" Apr 25, 2023
@seisman seisman added the final review call This PR requires final review and approval from a second reviewer label Apr 26, 2023
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Apr 26, 2023
@seisman seisman merged commit 47674e3 into main Apr 26, 2023
@seisman seisman deleted the fix-typos-31-linestyles branch April 26, 2023 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants