-
Notifications
You must be signed in to change notification settings - Fork 229
Fix the DataArray repr in the load_tile_map doctest for xarray v2024.02 #3062
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
seisman
commented
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
maintenance
Boring but important stuff for the core devs
skip-changelog
Skip adding Pull Request to changelog
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xarray v2024.2 was released in Feb, 2024. This new version changed the representation of DataArray (pydata/xarray#8690), making our one doctest failing(https://github.com/GenericMappingTools/pygmt/actions/runs/7982166393/job/21795212745):
We can't simply change the output to the new version, because our CI jobs are using different xarray versions (i.e., the minimum supported version with Python 3.10 and the latest version with Python 3.12). We can't make both happy.
We can only let doctest ignore the differences in whitespaces use ellipse for the newly added
nbytes
.