Skip to content

Quickfix plot docstring to have label (l) #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

weiji14
Copy link
Member

@weiji14 weiji14 commented Oct 31, 2019

Description of proposed changes

The code that sets label as an alias for l in plot is in the right place, but the docstring was accidentally placed under grdcontour instead of plot.

Note to future self/contributor: Wait for GenericMappingTools/gmt#1838 to actually use -l in grdcontour and contour.

Fixes #

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

The `l` argument docstring should be under plot, not grdcontour.
@weiji14 weiji14 mentioned this pull request Oct 31, 2019
5 tasks
@weiji14 weiji14 merged commit d39d0c9 into GenericMappingTools:master Oct 31, 2019
@weiji14 weiji14 deleted the quickfix/plot-label-alias branch October 31, 2019 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants