Skip to content

CI: Fix the condition check and permission in the Check Links workflow #3870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 25, 2025

Conversation

seisman
Copy link
Member

@seisman seisman commented Mar 25, 2025

Breaking changes in lychee-actions v2.0.0 (https://github.com/lycheeverse/lychee-action/releases/tag/v2.0.0).

Need to check exit code in step output rather than env.

Also need to set the permissons so that it can create an issue.

@seisman seisman added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog final review call This PR requires final review and approval from a second reviewer labels Mar 25, 2025
@seisman seisman added this to the 0.15.0 milestone Mar 25, 2025
@seisman
Copy link
Member Author

seisman commented Mar 25, 2025

@seisman seisman marked this pull request as ready for review March 25, 2025 03:01
@seisman seisman changed the title CI: Fix the condition check in the Check Links workflow CI: Fix the condition check and permission in the Check Links workflow Mar 25, 2025
@seisman seisman merged commit b1dff81 into main Mar 25, 2025
10 checks passed
@seisman seisman deleted the ci/check-links branch March 25, 2025 10:36
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants