Skip to content

DOC: Update URLs (Link Checker Report on 2025-03-25) #3875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 25, 2025
Merged

DOC: Update URLs (Link Checker Report on 2025-03-25) #3875

merged 8 commits into from
Mar 25, 2025

Conversation

yvonnefroehlich
Copy link
Member

@yvonnefroehlich yvonnefroehlich commented Mar 25, 2025

Description of proposed changes

Fixes #3871

Previews:

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash command is:

  • /format: automatically format and lint the code

@yvonnefroehlich yvonnefroehlich added the documentation Improvements or additions to documentation label Mar 25, 2025
@yvonnefroehlich yvonnefroehlich added this to the 0.15.0 milestone Mar 25, 2025
@yvonnefroehlich yvonnefroehlich self-assigned this Mar 25, 2025
@seisman
Copy link
Member

seisman commented Mar 25, 2025

Yes, need to add these them to .github/workflows/check-links.yml.

@seisman
Copy link
Member

seisman commented Mar 25, 2025

  • [ERROR] file:///home/runner/work/pygmt/pygmt/repository/doc/gallery/index.rst | Cannot find file
  • [ERROR] file:///home/runner/work/pygmt/pygmt/repository/doc/tutorials/index.rst | Cannot find file
  • [ERROR] file:///home/runner/work/pygmt/pygmt/repository/doc/intro/index.rst | Cannot find file
    -> using GALLERY_HEADER.rst does not work

Maybe just remove this sentence?

Start by looking at our Intro, Tutorials, and Gallery.

@yvonnefroehlich
Copy link
Member Author

Yes, need to add these them to .github/workflows/check-links.yml.

Thanks!! I knew that we have a file with the excluded links, but could not find it...

@seisman
Copy link
Member

seisman commented Mar 25, 2025

  • [ERROR] file:///home/runner/work/pygmt/pygmt/repository/doc/gallery/index.rst | Cannot find file
  • [ERROR] file:///home/runner/work/pygmt/pygmt/repository/doc/tutorials/index.rst | Cannot find file
  • [ERROR] file:///home/runner/work/pygmt/pygmt/repository/doc/intro/index.rst | Cannot find file
    -> using GALLERY_HEADER.rst does not work

Maybe just remove this sentence?

Start by looking at our Intro, Tutorials, and Gallery.

Wait. Maybe we should not check the .md files under the doc directory.

@yvonnefroehlich yvonnefroehlich changed the title WIP: DOC: Update URLs DOC: Update URLs Mar 25, 2025
@seisman seisman merged commit 8ea3f1d into main Mar 25, 2025
10 checks passed
@seisman seisman deleted the fix-urls branch March 25, 2025 17:09
@yvonnefroehlich yvonnefroehlich changed the title DOC: Update URLs DOC: Update URLs (Link Checker Report on 2025-03-25) Mar 30, 2025
@yvonnefroehlich yvonnefroehlich added skip-changelog Skip adding Pull Request to changelog maintenance Boring but important stuff for the core devs and removed documentation Improvements or additions to documentation labels Mar 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link Checker Report on 2025-03-25
2 participants