Skip to content

Reorganize GMTDataArrayAccessor to the pygmt.xarray module #3928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 28, 2025
Merged

Reorganize GMTDataArrayAccessor to the pygmt.xarray module #3928

merged 4 commits into from
Apr 28, 2025
+10 −10

Conversation

seisman
Copy link
Member

@seisman seisman commented Apr 26, 2025 •
edited
Loading

Address #3919 (comment).

This PR moves the pygmt/accessors.py to pygmt/xarray/accessor.py [singular vs plural] and also moves GMTDataArrayAccessor to the "Xarray Integration" section in the docs.

Preview: https://pygmt-dev--3928.org.readthedocs.build/en/3928/api/index.html#xarray-integration

@seisman seisman added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog needs review This PR has higher priority and needs review. labels Apr 26, 2025
@seisman seisman added this to the 0.16.0 milestone Apr 26, 2025
@seisman seisman requested a review from weiji14 April 26, 2025 02:17
@weiji14
Copy link
Member

weiji14 commented Apr 27, 2025

Probably should also rename test_accessor.py to test_xarray_accessor.py?

@seisman
Copy link
Member Author

seisman commented Apr 28, 2025

Done

weiji14
weiji14 approved these changes Apr 28, 2025
View reviewed changes
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, and rename the test function names from def test_accessor_* to def test_xarray_accessor_*? Not compulsory though.

@seisman seisman merged commit 4bbc37e into main Apr 28, 2025
24 checks passed
@seisman seisman deleted the xarray/accessor branch April 28, 2025 07:22
@seisman seisman removed the needs review This PR has higher priority and needs review. label Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weiji14 weiji14 weiji14 approved these changes

Assignees
No one assigned
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Milestone
0.16.0
Development

Successfully merging this pull request may close these issues.
2 participants
@seisman @weiji14