-
Notifications
You must be signed in to change notification settings - Fork 229
Add an example for different line styles #604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just had to look up how to plot dashed lines yesterday, and this would have been a super useful reference!
How do I set the milestone and project? Is it for 0.2.x or 0.3.x? |
Go for 0.2.x, there's some bug fixes left to do and we'll most likely need a 0.2.1 release. |
Here is a similar plot from matplotlib. In the matplotlib example, it's much easier to see the line style and the corresponding parameters. I plan to improve our "line styles" example, following the matplotlib one, with the parameters (e.g., |
Sounds like a good plan. We probably don't need 16 line examples though, just keep it minimal. Also, was just looking at the GMT.jl AGU gallery examples at https://www.generic-mapping-tools.org/GMT.jl/latest/gallery/tables/, looks like there's a lot of decorated arrows/curved line examples we can follow. |
Description of proposed changes
Add an example showing lines with different styles:
Preview: https://pygmt-crbc9dplm.vercel.app/gallery/line/linestyles.html
Address #493.
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.