Skip to content

Test if is_nonstr_iter works for numpy arrays #623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 20, 2020
Merged

Conversation

seisman
Copy link
Member

@seisman seisman commented Sep 20, 2020

Description of proposed changes

Add a doctest checking if function is_nonstr_iter works for numpy arrays.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

@seisman seisman added the maintenance Boring but important stuff for the core devs label Sep 20, 2020
@seisman seisman added this to the 0.2.1 milestone Sep 20, 2020
@seisman seisman requested a review from weiji14 September 20, 2020 22:42
@weiji14
Copy link
Member

weiji14 commented Sep 20, 2020

By the way, maybe add the skip-changelog label since this is a pretty small change.

@seisman seisman added the skip-changelog Skip adding Pull Request to changelog label Sep 20, 2020
@seisman seisman merged commit 7785566 into master Sep 20, 2020
@seisman seisman deleted the test/is_nonstr_iter branch September 20, 2020 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants