Skip to content

Move x2sys.py to src folder and split it into x2sys_init and x2sys_cross #951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 22, 2021
Merged

Move x2sys.py to src folder and split it into x2sys_init and x2sys_cross #951

merged 2 commits into from
Feb 22, 2021

Conversation

weiji14
Copy link
Member

@weiji14 weiji14 commented Feb 22, 2021

Description of proposed changes

Move the x2sys modules originally wrapped in #546. The single x2sys.py has been separated into x2sys_init.py and x2sys_cross.py inside the src/ folder as per #930 (review).

Addresses #807

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@weiji14
Move x2sys.py to src folder and split it into x2sys_init and x2sys_cross
a6d767f 
Move the x2sys modules originally wrapped in #546.
The single x2sys.py has been separated into x2sys_init.py
and x2sys_cross.py inside the src/ folder as per #807.
@weiji14 weiji14 added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Feb 22, 2021
@weiji14 weiji14 added this to the 0.3.1 milestone Feb 22, 2021
@weiji14 weiji14 marked this pull request as ready for review February 22, 2021 03:43
@weiji14 weiji14 merged commit ba879ea into master Feb 22, 2021
@weiji14 weiji14 deleted the split_x2sys_init_and_cross branch February 22, 2021 04:06
@weiji14 weiji14 mentioned this pull request Feb 22, 2021
Closed
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
@weiji14
Move x2sys.py to src folder and split it into x2sys_init and x2sys_cr…
bf4bf11 
…oss (GenericMappingTools#951)

Move the x2sys modules originally wrapped in GenericMappingTools#546.
The single x2sys.py has been separated into x2sys_init.py
and x2sys_cross.py inside the src/ folder as per GenericMappingTools#807.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seisman seisman seisman approved these changes

Assignees
No one assigned
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Milestone
0.3.1
Development

Successfully merging this pull request may close these issues.
2 participants
@weiji14 @seisman