Skip to content

Update plotting module docstrings to use parameter vs. argument #956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

willschlitzer
Copy link
Contributor

As discussed in #886, this pull requests updates the incorrect use of "argument" with "parameter." This pull request covers changes in the doc strings in the plotting modules.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@willschlitzer willschlitzer marked this pull request as ready for review February 22, 2021 20:58
@willschlitzer willschlitzer added documentation Improvements or additions to documentation skip-changelog Skip adding Pull Request to changelog labels Feb 22, 2021
Copy link
Member

@seisman seisman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a small issue.

@seisman seisman added this to the 0.3.1 milestone Feb 22, 2021
Co-authored-by: Dongdong Tian <[email protected]>
@seisman seisman changed the title Update plotting module doc strings to use parameter vs. argument Update plotting module docstrings to use parameter vs. argument Feb 22, 2021
@seisman seisman merged commit e30b2d7 into GenericMappingTools:master Feb 22, 2021
@willschlitzer willschlitzer deleted the plot-modules-parameter-argument branch February 22, 2021 22:36
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
…ricMappingTools#956)

* Update blockmedian.py
* Update coast.py
* Update grd2cpt.py
* Update grdinfo.py
* Update text.py
* Update pygmt/src/text.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants