[Polls] Add Poll Creation Flow #3433

nuno-vieira · 2024-09-25T11:37:25Z

🔗 Issue Links

Related to https://stream-io.atlassian.net/browse/PBE-4287

🎯 Goal

Adds the Poll Creation Flow.

🛠 Implementation

The PollCreationVC uses a UICollectionView with compositional layout instead of a regular UITableView. The reason is mainly related to the options sorting. The Stream's design requires using custom sorting implementation, and doing it in the collection view is simpler and more flexible than the table view.

graph LR
    PollCreationVC --> PollCreationSectionHeaderView
    PollCreationVC  --> PollCreationNameCell --> PollCreationTextFieldView
    PollCreationVC  --> PollCreationOptionCell --> PollCreationTextFieldView
    PollCreationVC  --> PollCreationFeatureCell --> PollCreationFeatureSwitchView
    PollCreationVC  --> PollCreationMultipleVotesFeatureCell --> PollCreationFeatureSwitchView

🧪 Manual Testing Notes

Only some smoke testing is required. Final and extensive QA should be done on the final PR.

☑️ Contributor Checklist

I have signed the Stream CLA (required)
This change should be manually QAed
Changelog is updated with client-facing changes
Changelog is updated with new localization keys
New code is covered by unit tests
Comparison screenshots added for visual changes
Affected documentation updated (docusaurus, tutorial, CMS)

* Introduce new ViewContainerBuilder * Add PollAttachmentView component * Change to SwiftUI ENV * Add `shouldShowOnlineIndicator` to turn off online presence in `ChatUserAvatarView` * Fix small iOS 13 deprecation * Add domain logic helpers to Poll * Message Polls live updates * Event.ownVotes workaround (Drop when fixed) * Manage data races when voting on a poll in the message list * Add haptic feedback when voting * Make sure to update the latestVotes author avatar views * Improve performance of Option List View by no recreating the item views everytime * Improve flexibility of Option List View without compromising performance * Make content of StackedUserAvatarsView public * Re-structure Common Buttons Folder * Add `CheckboxButton` as a common view * Add vote ratio logic to `ChatChannelListItemView` * Fix UI Glitches for option list item view when text is too big and avatar appears and disappears * Extract more common logic to `Poll` domain model * Add closed poll and winner option state logic * Add subtitle text logic to `PollAttachmentView` * Change winner logic to be the one and only one option with most votes * Add channel list message preview text for polls * Add poll quoted message text rendering * Add View Results and End Button to the Poll Attachment View * Fix poll option label width ui glitch * Added End Poll functionality * Add isOptionWinner and isOptionOneOfTheWinners to Poll * Fix message with Polls not showing when long pressing * Fix poll controller with incorrect data in message list * Sort the `latestVotes` and `latestAnswers` in the LLC * Add test coverage to Poll domain helpers * Add Test Coverage to Poll Message Preview in Channel List * Add test coverage to PollAttachmentView * Add test coverage to disabling online indicator in ChatUserAvatarView * Add test coverage to quoted poll * Fix some existing snapshot tests * Use UIStackView for Spacer() to avoid drawing * Fix Xcode 14 Build * Fix Poll AttachmentView Tests on CI * Update CHANGELOG.md * Update CHANGELOG.md * Fix Xcode 14 Build, conflict with SwiftUI Spacer * Revert "Change to SwiftUI ENV" This reverts commit 6d9129a. * Add documentation to ViewContainerBuilder * Fix vale issues * Fix using pin() instead of constraint() in docs

* Refactor PollResultsVC Section views to be more simple and flat hierarchy * Fix bottom spacing in Poll Results Section Header * Add comment buttons to `PollAttachmentView` * Add comment to poll implementation * Fix `poll.latestAnswers` being reset after poll event did not retreive the `latestAnswers` data We should not treat optional `latestAnswers` as empty, since they have different meanings * Add `PollCommentListVC` implementation * Fix `PollVoteListQueryDTO.filterHash` using filterHash only instead of queryHash This was causing the pollId to not be considered when fetching the DB votes * Make diffable data sources more stable * Fix first page of poll vote list resetting all votes * Fix the default vote list sorting * Add poll suggestions feature * Add anonymous polls support * Fix AlertsRouter docs * Add test coverage to `PollCommentListVC` * Add test coverage when poll comments are 0 * Add test coverage to allow suggestions * Add test coverage to anonymous polls * Re-record snapshots after renaming test file * Fix snapshot on CI * Update CHANGELOG.md * Update CHANGELOG.md * Update CHANGELOG.md * Update Sources/StreamChatUI/ChatMessageList/Attachments/Poll/PollAttachmentView.swift * Update Sources/StreamChatUI/ChatMessageList/Attachments/Poll/PollCommentListVC/PollCommentListSectionFooterView.swift * Fix comments and suggestion buttons showing when poll is closed * Update CHANGELOG.md * Change alert titles to follow Apples guideline * Improve comments view spacing * Optimize a bit to check if a user has already a comment

github-actions · 2024-09-25T11:40:36Z

	1 Warning
⚠️	Big PR

Generated by 🚫 Danger

Stream-SDK-Bot · 2024-09-25T11:45:56Z

SDK Size

`title`	`develop`	`branch`	`diff`	`status`
StreamChat	6.85 MB	6.8 MB	-56 KB	🚀
StreamChatUI	4.42 MB	4.89 MB	+487 KB	🟡

Stream-SDK-Bot · 2024-09-25T11:51:14Z

SDK Performance

`target`	`metric`	`benchmark`	`branch`	`performance`	`status`
MessageList	Hitches total duration	10 ms	4.17 ms	58.3% 🔼	🟢
	Duration	2.6 s	2.54 s	2.31% 🔼	🟢
	Hitch time ratio	4 ms per s	1.64 ms per s	59.0% 🔼	🟢
	Frame rate	75 fps	78.01 fps	4.01% 🔼	🟢
	Number of hitches	1	0.4	60.0% 🔼	🟢
ChannelList	Hitches total duration	12.5 ms	14.19 ms	-13.52% 🔽	🔴
	Duration	2.6 s	2.55 s	1.92% 🔼	🟢
	Hitch time ratio	5 ms per s	5.57 ms per s	-11.4% 🔽	🔴
	Frame rate	72 fps	74.36 fps	3.28% 🔼	🟢
	Number of hitches	1.2	1.4	-16.67% 🔽	🔴

Sources/StreamChatUI/ChatMessageList/Attachments/Poll/PollCreationVC/PollCreationVC.swift

Stream-SDK-Bot · 2024-09-25T14:43:24Z

SDK Size

`title`	`develop`	`branch`	`diff`	`status`
StreamChat	6.85 MB	6.88 MB	+34 KB	🟢
StreamChatUI	4.42 MB	4.89 MB	+490 KB	🟢

# Conflicts: # CHANGELOG.md # Sources/StreamChatUI/Appearance+Images.swift # Sources/StreamChatUI/Generated/L10n.swift # Sources/StreamChatUI/Navigation/AlertsRouter.swift # Sources/StreamChatUI/Resources/en.lproj/Localizable.strings # Sources/StreamChatUI/ViewContainerBuilder/ViewContainerBuilder.swift # StreamChat.xcodeproj/project.pbxproj

Co-authored-by: Stream Bot <[email protected]>

martinmitrevski

Looks good code wise. While testing a found a bug with the "add comments" button (see the PR comments).
Are you planning to add the docs in a separate PR?

...s/StreamChatUI/ChatMessageList/Attachments/Poll/PollCreationVC/PollCreationFeatureCell.swift

Sources/StreamChatUI/ChatMessageList/Attachments/Poll/PollCreationVC/PollCreationVC.swift

martinmitrevski · 2024-09-26T06:57:39Z

Sources/StreamChatUI/ChatMessageList/Attachments/Poll/PollCreationVC/PollCreationVC.swift

+    public static var multipleVotes = Self(rawValue: "multiple-votes")
+    public static var anonymous = Self(rawValue: "anonymous")
+    public static var suggestions = Self(rawValue: "suggestions")
+    public static var comments = Self(rawValue: "comments")


There's now one bug, which probably has been here all the time, but now easily visible with the comments creation option:

Create a poll with comments supported

Add comments is presented

Vote on any of the options

Add comments is removed
There's also a weird jump when this happens.

Yes, I'm aware of this issue, but I spent a bit of time trying to fix it, and could not fix it, it seems like it is a CoreData related issue. So I was planning on fix it in the final QA.

In relation to 4, I don't see any weird jump as well

ok, but let's fix it before merging to develop

laevandus · 2024-09-26T07:04:23Z

Sources/StreamChatUI/Utils/KeyboardHandler/DefaultScrollViewKeyboardHandler.swift

+        NotificationCenter.default.removeObserver(self)
+    }
+
+    // swiftlint:enable notification_center_detachment


We should probably remove this rule if we prefer not to use it in some cases.

Yeah we should eventually remove it

Disabled it already 👍 I've also disabled switch_case_alignment which was very annoying and goes against Xcode's default formatting

yeetd-normal.pkg

...ts/SnapshotTests/Composer/__Snapshots__/ComposerVC_Tests/test_showLinkPreview.small-dark.png

…bled

…eatureType

…nment

sonarqubecloud · 2024-09-26T11:22:06Z

Quality Gate passed

Issues
159 New issues
0 Accepted issues

Measures
0 Security Hotspots
84.1% Coverage on New Code
0.1% Duplication on New Code

See analysis details on SonarCloud

laevandus

Looks good, I think we should proceed with merging this to the main polls branch and proceeding from there (with testing and minor changes)

* [Polls] Add `PollAttachmentView` + `ViewContainerBuilder` (#3374) * Introduce new ViewContainerBuilder * Add PollAttachmentView component * Change to SwiftUI ENV * Add `shouldShowOnlineIndicator` to turn off online presence in `ChatUserAvatarView` * Fix small iOS 13 deprecation * Add domain logic helpers to Poll * Message Polls live updates * Event.ownVotes workaround (Drop when fixed) * Manage data races when voting on a poll in the message list * Add haptic feedback when voting * Make sure to update the latestVotes author avatar views * Improve performance of Option List View by no recreating the item views everytime * Improve flexibility of Option List View without compromising performance * Make content of StackedUserAvatarsView public * Re-structure Common Buttons Folder * Add `CheckboxButton` as a common view * Add vote ratio logic to `ChatChannelListItemView` * Fix UI Glitches for option list item view when text is too big and avatar appears and disappears * Extract more common logic to `Poll` domain model * Add closed poll and winner option state logic * Add subtitle text logic to `PollAttachmentView` * Change winner logic to be the one and only one option with most votes * Add channel list message preview text for polls * Add poll quoted message text rendering * Add View Results and End Button to the Poll Attachment View * Fix poll option label width ui glitch * Added End Poll functionality * Add isOptionWinner and isOptionOneOfTheWinners to Poll * Fix message with Polls not showing when long pressing * Fix poll controller with incorrect data in message list * Sort the `latestVotes` and `latestAnswers` in the LLC * Add test coverage to Poll domain helpers * Add Test Coverage to Poll Message Preview in Channel List * Add test coverage to PollAttachmentView * Add test coverage to disabling online indicator in ChatUserAvatarView * Add test coverage to quoted poll * Fix some existing snapshot tests * Use UIStackView for Spacer() to avoid drawing * Fix Xcode 14 Build * Fix Poll AttachmentView Tests on CI * Update CHANGELOG.md * Update CHANGELOG.md * Fix Xcode 14 Build, conflict with SwiftUI Spacer * Revert "Change to SwiftUI ENV" This reverts commit 6d9129a. * Add documentation to ViewContainerBuilder * Fix vale issues * Fix using pin() instead of constraint() in docs * [Polls] Add `PollResultsVC` (#3381) * [Polls] Comments + Suggestions + Anonymous Polls + LLC Fixes (#3398) * Refactor PollResultsVC Section views to be more simple and flat hierarchy * Fix bottom spacing in Poll Results Section Header * Add comment buttons to `PollAttachmentView` * Add comment to poll implementation * Fix `poll.latestAnswers` being reset after poll event did not retreive the `latestAnswers` data We should not treat optional `latestAnswers` as empty, since they have different meanings * Add `PollCommentListVC` implementation * Fix `PollVoteListQueryDTO.filterHash` using filterHash only instead of queryHash This was causing the pollId to not be considered when fetching the DB votes * Make diffable data sources more stable * Fix first page of poll vote list resetting all votes * Fix the default vote list sorting * Add poll suggestions feature * Add anonymous polls support * Fix AlertsRouter docs * Add test coverage to `PollCommentListVC` * Add test coverage when poll comments are 0 * Add test coverage to allow suggestions * Add test coverage to anonymous polls * Re-record snapshots after renaming test file * Fix snapshot on CI * Update CHANGELOG.md * Update CHANGELOG.md * Update CHANGELOG.md * Update Sources/StreamChatUI/ChatMessageList/Attachments/Poll/PollAttachmentView.swift * Update Sources/StreamChatUI/ChatMessageList/Attachments/Poll/PollCommentListVC/PollCommentListSectionFooterView.swift * Fix comments and suggestion buttons showing when poll is closed * Update CHANGELOG.md * Change alert titles to follow Apples guideline * Improve comments view spacing * Optimize a bit to check if a user has already a comment * Add poll creation action to composer if polls are enabled * Add Poll Creation Views and UX * Handle keyboard adjustment in the poll creation view * Add actual if-statement support to ViewContainerBuilder * Add Poll Creation View Styling * Add poll creation section header view * Add Poll Creation Feature Cell Styling * Add Multiple Votes Feature Cell Data handling * Improve data handling in PollCreationVC * Add poll creation button * Fix Poll Creation Memory Leaks + Add Poll Option Errors * Implement poll option error indices * Refactor Poll Creation View to Collection View * Add views to components and appearance * Implement keyboard management in Poll Creation VC * Implementation of discarding poll changes * Add poll alert error if creation fails * Fix basic features not being persisted * Add localization to the views * Add for polls feature support configuration * Add Poll Creation View test coverage * Update CHANGELOG.md * Fix test_canCreatePoll_whenOptionsError_shouldReturnFalse test * [CI] Snapshots (#3434) Co-authored-by: Stream Bot <[email protected]> * Fix maximum votes error not being cleared when multiple votes is disabled * Change multiple votes keyboard to number bad * Remove custom equatable implementation that is not required for PollFeatureType * Remove yeetd-normal.pkg file? * Fix adding duplicate options * Disable swiftlint notification_center_detachment and switch_case_alignment * Extract poll creation input view height to a constant --------- Co-authored-by: Stream SDK Bot <[email protected]> Co-authored-by: Stream Bot <[email protected]>

* [Polls] Add `PollAttachmentView` + `ViewContainerBuilder` (#3374) * Introduce new ViewContainerBuilder * Add PollAttachmentView component * Change to SwiftUI ENV * Add `shouldShowOnlineIndicator` to turn off online presence in `ChatUserAvatarView` * Fix small iOS 13 deprecation * Add domain logic helpers to Poll * Message Polls live updates * Event.ownVotes workaround (Drop when fixed) * Manage data races when voting on a poll in the message list * Add haptic feedback when voting * Make sure to update the latestVotes author avatar views * Improve performance of Option List View by no recreating the item views everytime * Improve flexibility of Option List View without compromising performance * Make content of StackedUserAvatarsView public * Re-structure Common Buttons Folder * Add `CheckboxButton` as a common view * Add vote ratio logic to `ChatChannelListItemView` * Fix UI Glitches for option list item view when text is too big and avatar appears and disappears * Extract more common logic to `Poll` domain model * Add closed poll and winner option state logic * Add subtitle text logic to `PollAttachmentView` * Change winner logic to be the one and only one option with most votes * Add channel list message preview text for polls * Add poll quoted message text rendering * Add View Results and End Button to the Poll Attachment View * Fix poll option label width ui glitch * Added End Poll functionality * Add isOptionWinner and isOptionOneOfTheWinners to Poll * Fix message with Polls not showing when long pressing * Fix poll controller with incorrect data in message list * Sort the `latestVotes` and `latestAnswers` in the LLC * Add test coverage to Poll domain helpers * Add Test Coverage to Poll Message Preview in Channel List * Add test coverage to PollAttachmentView * Add test coverage to disabling online indicator in ChatUserAvatarView * Add test coverage to quoted poll * Fix some existing snapshot tests * Use UIStackView for Spacer() to avoid drawing * Fix Xcode 14 Build * Fix Poll AttachmentView Tests on CI * Update CHANGELOG.md * Update CHANGELOG.md * Fix Xcode 14 Build, conflict with SwiftUI Spacer * Revert "Change to SwiftUI ENV" This reverts commit 6d9129a. * Add documentation to ViewContainerBuilder * Fix vale issues * Fix using pin() instead of constraint() in docs * [Polls] Add `PollResultsVC` (#3381) * [Polls] Comments + Suggestions + Anonymous Polls + LLC Fixes (#3398) * Refactor PollResultsVC Section views to be more simple and flat hierarchy * Fix bottom spacing in Poll Results Section Header * Add comment buttons to `PollAttachmentView` * Add comment to poll implementation * Fix `poll.latestAnswers` being reset after poll event did not retreive the `latestAnswers` data We should not treat optional `latestAnswers` as empty, since they have different meanings * Add `PollCommentListVC` implementation * Fix `PollVoteListQueryDTO.filterHash` using filterHash only instead of queryHash This was causing the pollId to not be considered when fetching the DB votes * Make diffable data sources more stable * Fix first page of poll vote list resetting all votes * Fix the default vote list sorting * Add poll suggestions feature * Add anonymous polls support * Fix AlertsRouter docs * Add test coverage to `PollCommentListVC` * Add test coverage when poll comments are 0 * Add test coverage to allow suggestions * Add test coverage to anonymous polls * Re-record snapshots after renaming test file * Fix snapshot on CI * Update CHANGELOG.md * Update CHANGELOG.md * Update CHANGELOG.md * Update Sources/StreamChatUI/ChatMessageList/Attachments/Poll/PollAttachmentView.swift * Update Sources/StreamChatUI/ChatMessageList/Attachments/Poll/PollCommentListVC/PollCommentListSectionFooterView.swift * Fix comments and suggestion buttons showing when poll is closed * Update CHANGELOG.md * Change alert titles to follow Apples guideline * Improve comments view spacing * Optimize a bit to check if a user has already a comment * [Polls] Add Poll Creation Flow (#3433) * [Polls] Add `PollAttachmentView` + `ViewContainerBuilder` (#3374) * Introduce new ViewContainerBuilder * Add PollAttachmentView component * Change to SwiftUI ENV * Add `shouldShowOnlineIndicator` to turn off online presence in `ChatUserAvatarView` * Fix small iOS 13 deprecation * Add domain logic helpers to Poll * Message Polls live updates * Event.ownVotes workaround (Drop when fixed) * Manage data races when voting on a poll in the message list * Add haptic feedback when voting * Make sure to update the latestVotes author avatar views * Improve performance of Option List View by no recreating the item views everytime * Improve flexibility of Option List View without compromising performance * Make content of StackedUserAvatarsView public * Re-structure Common Buttons Folder * Add `CheckboxButton` as a common view * Add vote ratio logic to `ChatChannelListItemView` * Fix UI Glitches for option list item view when text is too big and avatar appears and disappears * Extract more common logic to `Poll` domain model * Add closed poll and winner option state logic * Add subtitle text logic to `PollAttachmentView` * Change winner logic to be the one and only one option with most votes * Add channel list message preview text for polls * Add poll quoted message text rendering * Add View Results and End Button to the Poll Attachment View * Fix poll option label width ui glitch * Added End Poll functionality * Add isOptionWinner and isOptionOneOfTheWinners to Poll * Fix message with Polls not showing when long pressing * Fix poll controller with incorrect data in message list * Sort the `latestVotes` and `latestAnswers` in the LLC * Add test coverage to Poll domain helpers * Add Test Coverage to Poll Message Preview in Channel List * Add test coverage to PollAttachmentView * Add test coverage to disabling online indicator in ChatUserAvatarView * Add test coverage to quoted poll * Fix some existing snapshot tests * Use UIStackView for Spacer() to avoid drawing * Fix Xcode 14 Build * Fix Poll AttachmentView Tests on CI * Update CHANGELOG.md * Update CHANGELOG.md * Fix Xcode 14 Build, conflict with SwiftUI Spacer * Revert "Change to SwiftUI ENV" This reverts commit 6d9129a. * Add documentation to ViewContainerBuilder * Fix vale issues * Fix using pin() instead of constraint() in docs * [Polls] Add `PollResultsVC` (#3381) * [Polls] Comments + Suggestions + Anonymous Polls + LLC Fixes (#3398) * Refactor PollResultsVC Section views to be more simple and flat hierarchy * Fix bottom spacing in Poll Results Section Header * Add comment buttons to `PollAttachmentView` * Add comment to poll implementation * Fix `poll.latestAnswers` being reset after poll event did not retreive the `latestAnswers` data We should not treat optional `latestAnswers` as empty, since they have different meanings * Add `PollCommentListVC` implementation * Fix `PollVoteListQueryDTO.filterHash` using filterHash only instead of queryHash This was causing the pollId to not be considered when fetching the DB votes * Make diffable data sources more stable * Fix first page of poll vote list resetting all votes * Fix the default vote list sorting * Add poll suggestions feature * Add anonymous polls support * Fix AlertsRouter docs * Add test coverage to `PollCommentListVC` * Add test coverage when poll comments are 0 * Add test coverage to allow suggestions * Add test coverage to anonymous polls * Re-record snapshots after renaming test file * Fix snapshot on CI * Update CHANGELOG.md * Update CHANGELOG.md * Update CHANGELOG.md * Update Sources/StreamChatUI/ChatMessageList/Attachments/Poll/PollAttachmentView.swift * Update Sources/StreamChatUI/ChatMessageList/Attachments/Poll/PollCommentListVC/PollCommentListSectionFooterView.swift * Fix comments and suggestion buttons showing when poll is closed * Update CHANGELOG.md * Change alert titles to follow Apples guideline * Improve comments view spacing * Optimize a bit to check if a user has already a comment * Add poll creation action to composer if polls are enabled * Add Poll Creation Views and UX * Handle keyboard adjustment in the poll creation view * Add actual if-statement support to ViewContainerBuilder * Add Poll Creation View Styling * Add poll creation section header view * Add Poll Creation Feature Cell Styling * Add Multiple Votes Feature Cell Data handling * Improve data handling in PollCreationVC * Add poll creation button * Fix Poll Creation Memory Leaks + Add Poll Option Errors * Implement poll option error indices * Refactor Poll Creation View to Collection View * Add views to components and appearance * Implement keyboard management in Poll Creation VC * Implementation of discarding poll changes * Add poll alert error if creation fails * Fix basic features not being persisted * Add localization to the views * Add for polls feature support configuration * Add Poll Creation View test coverage * Update CHANGELOG.md * Fix test_canCreatePoll_whenOptionsError_shouldReturnFalse test * [CI] Snapshots (#3434) Co-authored-by: Stream Bot <[email protected]> * Fix maximum votes error not being cleared when multiple votes is disabled * Change multiple votes keyboard to number bad * Remove custom equatable implementation that is not required for PollFeatureType * Remove yeetd-normal.pkg file? * Fix adding duplicate options * Disable swiftlint notification_center_detachment and switch_case_alignment * Extract poll creation input view height to a constant --------- Co-authored-by: Stream SDK Bot <[email protected]> Co-authored-by: Stream Bot <[email protected]> * Add `padding()` to ViewContainerBuilder + Remove ViewContainerBuilder `layout` and `constraints` The layout and constraints function would not work at all because applying constraints before adding a view to hierarchy is not possibl.e * Fix votes impacting latest answers * Fix poll.ownVotes and poll.latestAnwers impacting each other by moving them to poll.latestVotes * Fix Poll Repository Tests * Fix reorder icon showing before adding a new option * Fix anonymous comments logic * Fix channel list message preview incorrect latest voter * Fix edit message appearing in poll attachment * Fix being able to tap on options in a closed poll * Change min votes to 2 when maximum votes enabled since 1 maximum is not multiple votes * Fix trophy not showing for poll results winner * Fix snapshot UI Tests * Fix section header tests * Remove unnecessary disabling of swiftlint rules * PR Feedback * Change the order of the latest votes so that the first one is the most recent one * Adds the `PollAllOptionsListVC` component * Add missing test coverage to `PollAllOptionsListVC` * Fix poll question tappable on the All Options view * Fix not allow creating poll with only 1 option * Fix snapshots of poll all options view * Fix Message Actions not scrollable when multiple options * Update CHANGELOG.md * Add documentation to Polls UIKit * Update Poll Configuration docs * Better consistency in Polls documentation titles * Improve Poll State documentation structure * Update Poll Vote List Controller documentation with new inits * [CI] Snapshots (#3441) Co-authored-by: Stream Bot <[email protected]> * Remove unwanted file --------- Co-authored-by: Stream SDK Bot <[email protected]> Co-authored-by: Stream Bot <[email protected]> Co-authored-by: Stream Bot <[email protected]>

nuno-vieira added 24 commits August 21, 2024 10:54

[Polls] Add PollResultsVC (#3381)

c3367cb

Add poll creation action to composer if polls are enabled

83b8a3f

Add Poll Creation Views and UX

b51e2d8

Handle keyboard adjustment in the poll creation view

dc4a341

Add actual if-statement support to ViewContainerBuilder

ad613d4

Add Poll Creation View Styling

558b350

Add poll creation section header view

6ec3a76

Add Poll Creation Feature Cell Styling

67dd534

Add Multiple Votes Feature Cell Data handling

43ad39f

Improve data handling in PollCreationVC

ec8e031

Add poll creation button

7c44dbe

Fix Poll Creation Memory Leaks + Add Poll Option Errors

b2b8468

Implement poll option error indices

45c75df

Refactor Poll Creation View to Collection View

3bfe4b5

Add views to components and appearance

6b65f66

Implement keyboard management in Poll Creation VC

d631d9d

Implementation of discarding poll changes

e6b8112

Add poll alert error if creation fails

052b8e5

Fix basic features not being persisted

a3e1a1b

Add localization to the views

2dd940a

Add for polls feature support configuration

8596789

Add Poll Creation View test coverage

f29b9f3

nuno-vieira added 🎨 SDK: StreamChatUI Tasks related to the StreamChatUI SDK ✅ Feature An issue or PR related to a feature labels Sep 25, 2024

nuno-vieira requested a review from a team as a code owner September 25, 2024 11:37

Update CHANGELOG.md

7427688

laevandus reviewed Sep 25, 2024

View reviewed changes

Sources/StreamChatUI/ChatMessageList/Attachments/Poll/PollCreationVC/PollCreationVC.swift Outdated Show resolved Hide resolved

Fix test_canCreatePoll_whenOptionsError_shouldReturnFalse test

f4bdab1

nuno-vieira force-pushed the add/polls-ui-base branch from 043725f to 21ac665 Compare September 25, 2024 17:34

nuno-vieira and others added 2 commits September 25, 2024 18:48

[CI] Snapshots (#3434)

a31277e

Co-authored-by: Stream Bot <[email protected]>

martinmitrevski reviewed Sep 26, 2024

View reviewed changes

laevandus reviewed Sep 26, 2024

View reviewed changes

yeetd-normal.pkg Outdated Show resolved Hide resolved

laevandus reviewed Sep 26, 2024

View reviewed changes

...ts/SnapshotTests/Composer/__Snapshots__/ComposerVC_Tests/test_showLinkPreview.small-dark.png Outdated Show resolved Hide resolved

nuno-vieira added 7 commits September 26, 2024 11:23

Fix maximum votes error not being cleared when multiple votes is disa…

87c9323

…bled

Change multiple votes keyboard to number bad

a10a7f9

Remove custom equatable implementation that is not required for PollF…

dc9cbb0

…eatureType

Remove yeetd-normal.pkg file?

2a7363a

Fix adding duplicate options

b534237

Disable swiftlint notification_center_detachment and switch_case_alig…

a174d2f

…nment

Extract poll creation input view height to a constant

46cd1d2

laevandus approved these changes Sep 26, 2024

View reviewed changes

martinmitrevski approved these changes Sep 26, 2024

View reviewed changes

nuno-vieira merged commit f0e76f6 into add/polls-ui-base Sep 26, 2024
15 checks passed

nuno-vieira deleted the add/polls-creation branch September 26, 2024 13:27

nuno-vieira mentioned this pull request Sep 26, 2024

Adds Polls UI Components + Introducing View Container Builder #3435

Merged

7 tasks

Stream-SDK-Bot mentioned this pull request Oct 2, 2024

4.64.0 Release #3442

Merged

[Polls] Add Poll Creation Flow #3433

[Polls] Add Poll Creation Flow #3433

Uh oh!

Conversation

nuno-vieira commented Sep 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Issue Links

🎯 Goal

🛠 Implementation

🧪 Manual Testing Notes

☑️ Contributor Checklist

Uh oh!

github-actions bot commented Sep 25, 2024

Uh oh!

Stream-SDK-Bot commented Sep 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

SDK Size

Uh oh!

Stream-SDK-Bot commented Sep 25, 2024

SDK Performance

Uh oh!

Uh oh!

Stream-SDK-Bot commented Sep 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

SDK Size

Uh oh!

martinmitrevski left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

martinmitrevski Sep 26, 2024

Choose a reason for hiding this comment

Uh oh!

nuno-vieira Sep 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

martinmitrevski Sep 26, 2024

Choose a reason for hiding this comment

Uh oh!

laevandus Sep 26, 2024

Choose a reason for hiding this comment

Uh oh!

nuno-vieira Sep 26, 2024

Choose a reason for hiding this comment

Uh oh!

nuno-vieira Sep 26, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud bot commented Sep 26, 2024

Quality Gate passed

Uh oh!

laevandus left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

nuno-vieira commented Sep 25, 2024 •

edited

Loading

Stream-SDK-Bot commented Sep 25, 2024 •

edited

Loading

Stream-SDK-Bot commented Sep 25, 2024 •

edited

Loading

nuno-vieira Sep 26, 2024 •

edited

Loading