Parsing Dash initial_arguments broken in v1.6.1

[gabegrand]

I've identified a regression in release 1.6.1 that causes a bug when parsing initial_arguments as a serialized string.

We have an app that uses initial_arguments as follows. The dash_initial_arguments is a string of serialized JSON that is generated via views.py and passed to the Django template via context.

{% plotly_app name="MyApp" ratio=1 initial_arguments=dash_initial_arguments %}

Prior to v1.6.1, this worked as intended. However, there was a change to dash_wrapper.py in v1.6.1 that removed the JSON deserialization logic. Specifically, this change occurred in cddf575.

initial_arguments is still a string, but since the parsing has been removed, this now results in the following error:

ValueError: dictionary update sequence element #0 has length 1; 2 is required

@sdementen or @sebastiendementen do you have any context for why this parsing logic was removed?

[sdementen]

@gabegrand not that I can recall! Sorry for the regression!

[gabegrand]

@sdementen No worries! Let us know if you're able to work the fix into the next release. Thanks!

[sdementen]

hi @gabegrand,
could you check the fix on your side/case ?

[gabegrand]

I've confirmed that downgrading to v1.6.0 does fix the error!

[ghost]

Sorry, I meant "can you check if the PR fixes your issue ?"

…

________________________________ From: Gabe Grand ***@***.***> Sent: Tuesday, March 16, 2021 6:12:20 PM To: GibbsConsulting/django-plotly-dash ***@***.***> Cc: DE MENTEN Sébastien (Electrabel) ***@***.***>; Mention ***@***.***> Subject: ⚠️ Re: [GibbsConsulting/django-plotly-dash] Parsing Dash initial_arguments broken in v1.6.1 (#328) I've confirmed that downgrading to v1.6.0 does fix the error! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://urldefense.com/v3/__https://github.com/GibbsConsulting/django-plotly-dash/issues/328*issuecomment-800449501__;Iw!!La4veWw!gAeoL20ghSePBzxvX_n9GH-cyPHZ9X1z1_HIqyXpeEQXLxF0Nc5yv8QpL0khNzmsAxoj$>, or unsubscribe<https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AJ3HA3IUJN226D5UXKZB4KDTD6GPJANCNFSM4ZHCGSNQ__;!!La4veWw!gAeoL20ghSePBzxvX_n9GH-cyPHZ9X1z1_HIqyXpeEQXLxF0Nc5yv8QpL0khN6CfWHuR$>. ⚠️ This symbol is automatically added to emails originating from outside of the organization. Be extra careful with hyperlinks and attachments. ENGIE Mail Disclaimer: http://www.engie.com/disclaimer/

[GibbsConsulting]

Looks like merging the PR automatically closed the issue. The fix is now released as 1.6.2 - please reopen this issue if it doesn't address it.

[gabegrand]

@GibbsConsulting @sdementen thanks very much for the prompt fix!

[sdementen]

and did the fix work?

…

On Thu, Mar 18, 2021 at 5:18 PM Gabe Grand ***@***.***> wrote: @GibbsConsulting <https://github.com/GibbsConsulting> @sdementen <https://github.com/sdementen> thanks very much for the prompt fix! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#328 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJ6S5WIRJV3ZVX5325KKC3TEIRVTANCNFSM4ZHCGSNQ> .

[gabegrand]

Yes, the fix did work :)