Fix path separator and quotation issues in MSBuild task #2547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianbartel
force-pushed
the
issue-2534
branch
from
c03c05c to
1190f54
Compare
arturcic
approved these changes
Jan 15, 2021
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are several issues with the MSBuild task when it runs on file paths being different from usual situations.
Related Issue
Fixes #2534
Motivation and Context
The MSBuild task should be more reliable when it comes to uncommon project paths.
How Has This Been Tested?
I could not find any automated tests covering MSBuild scripts, so I simply patched my local cache of the package with the fixed .props file to see if that solves the issues I had. I doubt this is enough but I have no idea what more could be done on that.
Screenshots (if appropriate):
N/A
Checklist:
My code follows the code style of this project.Actually no code was changedMy change requires a change to the documentation.NoI have updated the documentation accordingly.I have added tests to cover my changes.I did not find automated tests for the .props/.targets portion. If I missed something here, let me know and I will reopen this tasknew andexisting tests passed.