Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add loading indicator #3052

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add loading indicator #3052

wants to merge 1 commit into from

Conversation

gregberge
Copy link
Contributor

@gregberge gregberge commented Mar 26, 2025 •
edited
Loading

CleanShot.2025-03-26.at.21.49.02.mp4

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 26, 2025

⚠️ No Changeset found

Latest commit: 5fdb854

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

Summary of the deployments:

Version 1 (production)

Version URL Status
Latest commit https://5888ef6f.gitbook-open.pages.dev ✅
PR https://pr3052.gitbook-open.pages.dev ✅

Version 2 (experimental)

Version URL Status
Vercel https://gitbook-v2-hf0j02x6l-gitbook.vercel.app ✅
Cloudflare https://14582145-gitbook-open-v2-preview.gitbook.workers.dev ✅

Test content

Site v1 v2
GitBook https://5888ef6f.gitbook-open.pages.dev/docs.gitbook.com https://gitbook-v2-hf0j02x6l-gitbook.vercel.app/url/docs.gitbook.com
E2E https://5888ef6f.gitbook-open.pages.dev/gitbook.gitbook.io/test-gitbook-open https://gitbook-v2-hf0j02x6l-gitbook.vercel.app/url/gitbook.gitbook.io/test-gitbook-open

@argos-ci Argos CI
Copy link

argos-ci bot commented Mar 26, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
customers-v1 (Inspect) ✅ No changes detected - Mar 26, 2025, 8:54 PM
customers-v2 (Inspect) ⚠️ Changes detected (Review) 1 changed Mar 26, 2025, 8:56 PM
default (Inspect) ⚠️ Changes detected (Review) 1 changed Mar 26, 2025, 8:56 PM
v2-vercel (Inspect) ⚠️ Changes detected (Review) 2 changed Mar 26, 2025, 8:59 PM

taranvohra
taranvohra reviewed Mar 27, 2025
View reviewed changes
packages/gitbook/src/components/RootLayout/CustomizationRootLayout.tsx
@@ -151,6 +151,7 @@ export async function CustomizationRootLayout(props: {
}
`}</style>
</head>
<HolyLoader color="rgb(var(--primary-9))" height={1} />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly I never liked these loaders. They're not very apparent and user friendly 😅. Why not try to use the skeleton grid we had in v1? It looks much better!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to submit a PR with it to see if it works.

Now that we are sure we can detect the loading of a page we can adapt to do whatever we want!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taranvohra taranvohra taranvohra left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gregberge @taranvohra