Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update opennext to 1.0.0-beta.0 #3102

Merged
merged 33 commits into from
Apr 5, 2025
Merged

Update opennext to 1.0.0-beta.0 #3102

merged 33 commits into from
Apr 5, 2025

Conversation

SamyPesse
Copy link
Member

No description provided.

Copy link

changeset-bot bot commented Apr 5, 2025

⚠️ No Changeset found

Latest commit: 67375d6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Apr 5, 2025

Copy link

argos-ci bot commented Apr 5, 2025

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
customers-v1 (Inspect) 👍 Changes approved 4 changed Apr 5, 2025, 9:24 PM
customers-v2 (Inspect) 👍 Changes approved 4 changed Apr 5, 2025, 9:27 PM
default (Inspect) ✅ No changes detected - Apr 5, 2025, 9:48 PM
v2-vercel (Inspect) ✅ No changes detected - Apr 5, 2025, 9:28 PM

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 13 out of 15 changed files in this pull request and generated 1 comment.

Files not reviewed (2)
  • packages/gitbook-v2/package.json: Language not supported
  • packages/gitbook-v2/wrangler.jsonc: Language not supported
Comments suppressed due to low confidence (1)

packages/gitbook-v2/src/lib/data/memoize.test.ts:49

  • [nitpick] The hard-coded expected cache key value in this test makes the test brittle if the serialization of the cache key changes. Consider computing the expected cache key dynamically to safeguard against future modification of the key generation logic.
expect(await memoized({ a: 1, b: 2 }, 4)).toBe('[[["a",1],["b",2]],4], result=7');

@SamyPesse SamyPesse marked this pull request as ready for review April 5, 2025 21:28
@SamyPesse SamyPesse merged commit 7fbf01a into main Apr 5, 2025
18 checks passed
@SamyPesse SamyPesse deleted the opennext-update branch April 5, 2025 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants