Fix the site canonical URL to include the visitor token if necessary #3126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 30aaf66 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
taranvohra
commented
Apr 9, 2025
Comment on lines
156
to
+158
| const incomingURL = mode === 'url' ? requestURL : siteCanonicalURL; | ||
| const requestURLWithoutToken = normalizeVisitorAuthURL(incomingURL); | ||
| if ( | ||
| requestURLWithoutToken !== incomingURL && | ||
| requestURLWithoutToken.toString() !== incomingURL.toString() | ||
| ) { | ||
| const incomingURLWithoutToken = normalizeVisitorAuthURL(incomingURL); | ||
| if (incomingURLWithoutToken.toString() !== incomingURL.toString()) { |
There was a problem hiding this comment.
For proxy requests our incoming URL is the siteCanonicalURL but it does not include the va token. So a VA site when proxied would not remove the token from the URL after a successful resolution. But with this PR it fixes that
|
Summary of the deployments: Version 1 (production)
Version 2 (experimental)
Test content |
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
|
Closing in favor of #3127 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise VA sites using the proxy would not remove the token from the URL