improvements for onefetch
#368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The methods returning an iterator are now consuming, which allows them to be nested by callers.
Also: parent_ids() queryable directly on commit.
It's a type with only copyable types inside, so should be copy itself. This makes it less awkward to use as well.
It's now self-contained.
Get a short-hand for any reference name.
It's definitely more intuitive that way.
This helps to tune caches. Linux v5.16 - Max commit Size: 74428 - Avg commit Size: 833
This is not what git seems to do, but it yields better results as more entries are unified and assigned to their respective authors. And it's valid, as emails are case-insensitive so they should match that way when unifying them.
It's separated from parsing to assure we can round-trip, but it's made easy to obtain trimmed results using new methods. This high-level git-repository will also trim by default now.
This results in one less name counted in the linux kernel, which probably means that one name (maybe a bot) was used to commit a commit. That's acceptable inaccuracy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #364