Skip to content
This repository was archived by the owner on Sep 8, 2022. It is now read-only.

moving the app.id and app.version configuration to only pom.xml #11

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

arsenicraghav
Copy link

@arsenicraghav arsenicraghav commented Aug 10, 2016

As we are using maven, it would be better if we have the app.id and app.version configuration in pom.xml just in once place and then use these properties in appengine-web.xml. Also need to add the app.id and app.version to the configuration of appengine-maven-plugin as it is required when deploying and if absent throws an error and hence works like a bug fix.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@arsenicraghav
Copy link
Author

I have signed it!

Thanks

On Wed, Aug 10, 2016 at 6:12 PM, googlebot [email protected] wrote:

Thanks for your pull request. It looks like this may be your first
contribution to a Google open source project. Before we can look at your
pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/
https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll

verify. Thanks.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#11 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJCWnuNTcKM7NR6KBKhKuCkAsLQIaf9uks5qeccbgaJpZM4JhGeY
.

Raghvendra Kumar

Sr. Analyst | Google Practice | Cloud First Applications

D: +91 22-43870645 M : +91 9620693638

@googlebot
Copy link

CLAs look good, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants