Skip to content

Adjust path handling #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 4, 2020
Merged

Adjust path handling #121

merged 2 commits into from
Mar 4, 2020

Conversation

hdp617
Copy link
Contributor

@hdp617 hdp617 commented Mar 3, 2020

  • paths with favicon.ico and robots.txt will send 404 and no longer invoke function.

hdp617 added 2 commits March 3, 2020 08:32
@hdp617
Remove --dry-run option.
48d3111
@hdp617
feat: send 404 for favicon.ico and robots.txt.
b95d80c 
BREAKING CHANGE: paths with favicon.ico and robots.txt will send 404 and no longer invoke function.
@hdp617 hdp617 requested review from grant and squee1945 March 3, 2020 16:36
@hdp617 hdp617 linked an issue Mar 3, 2020 that may be closed by this pull request
functions called from browser execute twice #33
Closed
@hdp617 hdp617 merged commit d61c084 into master Mar 4, 2020
@hdp617 hdp617 deleted the huy-ff branch March 4, 2020 22:17
@asriniva asriniva mentioned this pull request Mar 27, 2020
Closed
@asriniva asriniva mentioned this pull request Apr 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grant grant grant approved these changes

@squee1945 squee1945 Awaiting requested review from squee1945

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

functions called from browser execute twice
3 participants
@hdp617 @grant @googlebot