Skip to content

Add Spanner region tags. #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 1, 2018
Merged

Add Spanner region tags. #403

merged 4 commits into from
Mar 1, 2018

Conversation

jmdobry
Copy link
Member

@jmdobry jmdobry commented Mar 1, 2018 •
edited
Loading

@jmdobry jmdobry requested a review from broady March 1, 2018 04:46
This was referenced Mar 1, 2018
Merged
Merged
Merged
Merged
Merged
Merged
@jmdobry jmdobry self-assigned this Mar 1, 2018
@jmdobry jmdobry requested a review from jsimonweb March 1, 2018 18:14
broady
broady reviewed Mar 1, 2018
View reviewed changes
spanner/spanner_quickstart/main.go Outdated
@@ -3,6 +3,7 @@
// license that can be found in the LICENSE file.

// Sample spanner_quickstart is a basic program that uses Cloud Spanner.
// [START spanner_quickstart]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move this above the doc comment, or below it. As it is, it'll be included in package docs.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

broady
broady reviewed Mar 1, 2018
View reviewed changes
spanner/spanner_snippets/snippet.go Outdated
@@ -80,9 +81,11 @@ func createDatabase(ctx context.Context, w io.Writer, adminClient *database.Data
}
fmt.Fprintf(w, "Created database [%s]\n", db)
return nil
// [END spanner_create_database]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move the end tags above the final return statement.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@broady
Copy link
Contributor

broady commented Mar 1, 2018 •
edited
Loading

Please run gofmt over the CL after the comments are addressed.

Something like this, maybe, if you don't have Go installed:

docker run -v $PWD:/gosrc -t golang bash -c 'gofmt -w $(find /gosrc -name *.go)'

@jmdobry
Copy link
Member Author

jmdobry commented Mar 1, 2018

Done

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@broady broady merged commit 3ffcae6 into master Mar 1, 2018
@broady broady deleted the spanner-cleanup branch March 1, 2018 20:12
danicat pushed a commit that referenced this pull request Jul 28, 2018
@jmdobry @broady
spanner: add region tags (#403)
f96817d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@broady broady broady left review comments

@jsimonweb jsimonweb Awaiting requested review from jsimonweb

Assignees

@jmdobry jmdobry

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmdobry @broady @googlebot