Session Handling with Firestore tutorial. #1746
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
dzlier-gcp
added
the
kokoro:run
kokoro-team
removed
the
kokoro:run
kurtisvg
suggested changes
Nov 19, 2019
run/session-handling/src/main/java/com/example/gettingstarted/actions/HelloWorldServlet.java
Outdated
Show resolved
Hide resolved
run/session-handling/src/main/java/com/example/gettingstarted/actions/HelloWorldServlet.java
Outdated
Show resolved
Hide resolved
run/session-handling/src/main/java/com/example/gettingstarted/actions/HelloWorldServlet.java
Outdated
Show resolved
Hide resolved
run/session-handling/src/main/java/com/example/gettingstarted/util/FirestoreSessionFilter.java
Outdated
Show resolved
Hide resolved
run/session-handling/src/main/java/com/example/gettingstarted/util/FirestoreSessionFilter.java
Outdated
Show resolved
Hide resolved
run/session-handling/src/main/java/com/example/gettingstarted/util/FirestoreSessionFilter.java
Outdated
Show resolved
Hide resolved
run/session-handling/src/main/java/com/example/gettingstarted/util/FirestoreSessionFilter.java
Outdated
Show resolved
Hide resolved
run/session-handling/src/main/test/java/com/example/getstarted/actions/UserJourneyTestIT.java
Outdated
Show resolved
Hide resolved
dzlier-gcp
force-pushed
the
master
branch
2 times, most recently
from
29cdc06 to
d41b4de
Compare
|
feedback done |
dzlier-gcp
force-pushed
the
master
branch
2 times, most recently
from
a73f999 to
d41b4de
Compare
|
Ping |
kurtisvg
suggested changes
Nov 26, 2019
| } | ||
| String greeting = greetingValue.toString(); | ||
|
|
||
| System.out.println("Writing response " + req.toString()); |
There was a problem hiding this comment.
This is still printing to stdout
run/session-handling/src/main/java/com/example/gettingstarted/util/FirestoreSessionFilter.java
Outdated
Show resolved
Hide resolved
run/session-handling/src/main/test/java/com/example/getstarted/actions/UserJourneyTestIT.java
Outdated
Show resolved
Hide resolved
dzlier-gcp
force-pushed
the
master
branch
2 times, most recently
from
9e08472 to
71423fb
Compare
|
Other feedback changes done. |
kurtisvg
suggested changes
Dec 4, 2019
run/session-handling/src/main/java/com/example/gettingstarted/util/FirestoreSessionFilter.java
Outdated
Show resolved
Hide resolved
run/session-handling/src/main/java/com/example/gettingstarted/util/FirestoreSessionFilter.java
Outdated
Show resolved
Hide resolved
run/session-handling/src/main/java/com/example/gettingstarted/util/FirestoreSessionFilter.java
Outdated
Show resolved
Hide resolved
|
Ping |
|
I think the other Run tutorials are written differently for testing purposes, as they have their own special test run script in Kokoro that doesn't seem to work with this one. I'm moving the sample to the base directory. |
kurtisvg
approved these changes
Dec 16, 2019
run/session-handling/src/main/java/com/example/gettingstarted/util/FirestoreSessionFilter.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.