Skip to content

Read and Filter Snippets #1747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 3, 2019
Merged

Read and Filter Snippets #1747

merged 7 commits into from
Dec 3, 2019

Conversation

billyjacobson
Copy link
Member

@billyjacobson billyjacobson commented Nov 20, 2019

Snippets for reading and filtering data from cloud bigtable

@billyjacobson billyjacobson added the needs work This is a pull request that needs a little love. label Nov 20, 2019
@billyjacobson billyjacobson requested a review from a team November 20, 2019 21:46
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 20, 2019
@kurtisvg
Copy link
Contributor

@billyjacobson - Can you please ping me when this is ready for a review?

In the future, you can open a Draft PR so that reviewers aren't applied until you are ready.

@billyjacobson
Copy link
Member Author

@kurtisvg I think it's ready for a review now. Thanks for showing the draft PR thing, that's so cool

@billyjacobson billyjacobson removed the needs work This is a pull request that needs a little love. label Nov 22, 2019
assertThat(output)
.contains(
String.format(
"Reading data for phone#4c410523#20190501\n"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to define a regex for a single entry and verify it applies X number of times instead?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That wouldn't really test this accurately then since there are various combinations which would give the same number of cells that are different

@billyjacobson billyjacobson added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Nov 27, 2019
@kokoro-team kokoro-team removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Nov 27, 2019
@billyjacobson
Copy link
Member Author

@kurtisvg Could you take another look? The test for Java 8 seems to be failing right now, but the error says this which doesn't make sense INVALID_ARGUMENT: When parsing 'projects/java-docs-samples-testing/instances/instance' : Instance name expected in the form 'projects/<project_id>/instances/<instance_id>'.

@kurtisvg
Copy link
Contributor

kurtisvg commented Dec 2, 2019

@kurtisvg Could you take another look? The test for Java 8 seems to be failing right now, but the error says this which doesn't make sense INVALID_ARGUMENT: When parsing 'projects/java-docs-samples-testing/instances/instance' : Instance name expected in the form 'projects/<project_id>/instances/<instance_id>'.

It doesn't make sense to me either, and it looks like it's being returned by the API. Is instance the correct instance id?

@kurtisvg kurtisvg added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 2, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 2, 2019
@billyjacobson
Copy link
Member Author

billyjacobson commented Dec 2, 2019 via email

@kurtisvg kurtisvg added the kokoro:run Add this label to force Kokoro to re-run the tests. label Dec 2, 2019
@kurtisvg
Copy link
Contributor

kurtisvg commented Dec 2, 2019

Looking into this at the moment - so far I'm able to run everything locally.

@kurtisvg kurtisvg added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:run Add this label to force Kokoro to re-run the tests. labels Dec 3, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 3, 2019
@kurtisvg
Copy link
Contributor

kurtisvg commented Dec 3, 2019

One thing I've noticed - there is a nested project conflict going on - there are is a pom in bigquery and another in bigquery/snippets. The failing tests are actulaly coming from bigquery.

@kurtisvg
Copy link
Contributor

kurtisvg commented Dec 3, 2019

Different tests wasn't the problem - both tests are failing with the same error. I've tried running this in the container with the same project, service account, and command but I'm completely unable to replicate.

Judging from the stack trace, it looks like this error is coming from the API itself. I'm not sure if it's an encoding issue (seems unlikely, UTF-8 is specified in the pom) but at this point it seems like it might be worth it to reach out to someone that works on the API and see if they can retrieve more details on what's going on.

@billyjacobson billyjacobson added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 3, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 3, 2019
@billyjacobson billyjacobson added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 3, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 3, 2019
@billyjacobson billyjacobson added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 3, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 3, 2019
@kurtisvg kurtisvg added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 3, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 3, 2019
@kurtisvg kurtisvg added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 3, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 3, 2019
@billyjacobson billyjacobson merged commit 154cbd3 into master Dec 3, 2019
@lesv lesv deleted the reads branch January 17, 2020 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants