-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Read and Filter Snippets #1747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Read and Filter Snippets #1747
Conversation
@billyjacobson - Can you please ping me when this is ready for a review? In the future, you can open a Draft PR so that reviewers aren't applied until you are ready. |
@kurtisvg I think it's ready for a review now. Thanks for showing the draft PR thing, that's so cool |
bigtable/snippets/src/main/java/com/example/bigtable/Filters.java
Outdated
Show resolved
Hide resolved
bigtable/snippets/src/main/java/com/example/bigtable/Filters.java
Outdated
Show resolved
Hide resolved
bigtable/snippets/src/main/java/com/example/bigtable/Reads.java
Outdated
Show resolved
Hide resolved
bigtable/snippets/src/main/java/com/example/bigtable/Reads.java
Outdated
Show resolved
Hide resolved
assertThat(output) | ||
.contains( | ||
String.format( | ||
"Reading data for phone#4c410523#20190501\n" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to define a regex for a single entry and verify it applies X number of times instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That wouldn't really test this accurately then since there are various combinations which would give the same number of cells that are different
@kurtisvg Could you take another look? The test for Java 8 seems to be failing right now, but the error says this which doesn't make sense INVALID_ARGUMENT: When parsing 'projects/java-docs-samples-testing/instances/instance' : Instance name expected in the form 'projects/<project_id>/instances/<instance_id>'. |
It doesn't make sense to me either, and it looks like it's being returned by the API. Is |
"instance" is the correct instance ID, and I just checked to ensure that it
still exists and it's there.
…On Mon, Dec 2, 2019 at 4:26 PM Kurtis Van Gent ***@***.***> wrote:
@kurtisvg <https://github.com/kurtisvg> Could you take another look? The
test for Java 8 seems to be failing right now, but the error says this
which doesn't make sense INVALID_ARGUMENT: When parsing
'projects/java-docs-samples-testing/instances/instance' : Instance name
expected in the form 'projects/<project_id>/instances/<instance_id>'.
It doesn't make sense to me either, and it looks like it's being returned
by the API. Is instance the correct instance id?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1747?email_source=notifications&email_token=ABL2IT4YZE4KB6A6L7G7XW3QWV4QBA5CNFSM4JPZXZHKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFU6KPA#issuecomment-560588092>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABL2IT52OYMEWTBOQ7AT2WLQWV4QBANCNFSM4JPZXZHA>
.
--
*• **Billy Jacobson*
*•* Developer Programs Engineer,
*• *Google Cloud Developer Relations
*•* 111 8th Ave, New York, NY 10011
<https://maps.google.com/?q=111+8th+Ave,+New+York,+NY+10011&entry=gmail&source=g>
|
bigtable/snippets/src/test/java/com/example/bigtable/ReadsTest.java
Outdated
Show resolved
Hide resolved
Looking into this at the moment - so far I'm able to run everything locally. |
Adding comments about filtering Handling exceptions Reformatting Reads print output other cleanups
One thing I've noticed - there is a nested project conflict going on - there are is a pom in |
Different tests wasn't the problem - both tests are failing with the same error. I've tried running this in the container with the same project, service account, and command but I'm completely unable to replicate. Judging from the stack trace, it looks like this error is coming from the API itself. I'm not sure if it's an encoding issue (seems unlikely, UTF-8 is specified in the pom) but at this point it seems like it might be worth it to reach out to someone that works on the API and see if they can retrieve more details on what's going on. |
Snippets for reading and filtering data from cloud bigtable