Use libraries-bom for snippets - part 2 #1781
Conversation
googlebot
added
the
cla: yes
| <!-- [END dependencies] --> | ||
| <dependency> | ||
| <groupId>junit</groupId> | ||
| <artifactId>junit</artifactId> | ||
| <version>4.12</version> | ||
| <scope>test</scope> | ||
| </dependency> | ||
| <!-- [START dependencies] --> |
There was a problem hiding this comment.
These are intentional - the snippet is showing the following:
<dependencyManagement>
// bom stuff here
</dependencyManagement>
<dependencies>
<dependency>
// included dependency
</dependency>
// excluded dependencies
</dependencies>
There was a problem hiding this comment.
But it's using the same tag name as above in the same file, does that work?
There was a problem hiding this comment.
@kurtisvg can you confirm this is ok to do?
There was a problem hiding this comment.
Yes - there are two ways to have "multi-part" snippets. You can use [START_EXCLUDE]/[END_EXCLUDE] or you can just end the tag and start it in the correct place (see http://go/code-snippets-201#including-code-from-multiple-sections-of-a-file)
| </dependencies> | ||
| <!-- [END dependencies] --> |
| @@ -59,8 +69,9 @@ | |||
| <version>4.13-beta-3</version> | |||
| <scope>test</scope> | |||
| </dependency> | |||
| <!-- [START fs-maven] --> | |||
There was a problem hiding this comment.
Remove these and check the rest of your changes for these weird tags, looks like a merge error.
|
@kurtisvg @dzlier-gcp I think all comments are addressed, mind taking another look? |
Towards #1761