Skip to content

Create Java code sample for create job #3017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 2, 2020
Merged

Create Java code sample for create job #3017

merged 6 commits into from
Jun 2, 2020

Conversation

chloeliu123
Copy link
Contributor

https://cloud.google.com/dlp/docs/creating-job-triggers

Fixes #Create Java code sample for create job

It's a good idea to open an issue first for discussion.

[yes] I have followed Sample Format Guide
[yes] pom.xml parent set to latest shared-configuration
[yes] Appropriate changes to README are included in PR
[nothing new] API's need to be enabled to test (tell us)
[nothing new] Environment Variables need to be set (ask us to set them)
[yes] Tests pass (mvn -P lint clean verify)
(Note- Checkstyle passing is required; Spotbugs, ErrorProne, PMD, etc. ERROR's are advisory only)
[yes] Please merge this PR for me once it is approved

@chloeliu123 chloeliu123 requested a review from a team June 2, 2020 14:46
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 2, 2020
@lesv
Copy link
Contributor

lesv commented Jun 2, 2020

Could you join the gcp org at github/ -- I'll start reviewing.

@lesv lesv added automerge Merge the pull request once unit tests and other checks pass. kokoro:run Add this label to force Kokoro to re-run the tests. labels Jun 2, 2020
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 2, 2020
@lesv
Copy link
Contributor

lesv commented Jun 2, 2020

Looks good - thanks! It will merge if it passes Kokoro, if not, please fix and mention me in a comment.

@gcf-merge-on-green gcf-merge-on-green bot merged commit 2dfc807 into GoogleCloudPlatform:master Jun 2, 2020
@chloeliu123
Copy link
Contributor Author

Thanks for the review!

jakubrauch pushed a commit to jakubrauch/java-docs-samples that referenced this pull request Jun 4, 2020
https://cloud.google.com/dlp/docs/creating-job-triggers

Fixes #Create Java code sample for create job

> It's a good idea to open an issue first for discussion.

> [yes] I have followed Sample Format Guide
> [yes] pom.xml parent set to latest shared-configuration
> [yes] Appropriate changes to README are included in PR
> [nothing new] API's need to be enabled to test (tell us)
> [nothing new] Environment Variables need to be set (ask us to set them)
> [yes] Tests pass (mvn -P lint clean verify)
> (Note- Checkstyle passing is required; Spotbugs, ErrorProne, PMD, etc. ERROR's are advisory only)
> [yes] Please merge this PR for me once it is approved
Sita04 pushed a commit that referenced this pull request Feb 7, 2023
https://cloud.google.com/dlp/docs/creating-job-triggers

Fixes #Create Java code sample for create job

> It's a good idea to open an issue first for discussion.

> [yes] I have followed Sample Format Guide
> [yes] pom.xml parent set to latest shared-configuration
> [yes] Appropriate changes to README are included in PR
> [nothing new] API's need to be enabled to test (tell us)
> [nothing new] Environment Variables need to be set (ask us to set them)
> [yes] Tests pass (mvn -P lint clean verify)
> (Note- Checkstyle passing is required; Spotbugs, ErrorProne, PMD, etc. ERROR's are advisory only)
> [yes] Please merge this PR for me once it is approved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants