Skip to content

Commit 12a666d

Browse files
authored
Use valid format for App Engine version string (#663)
argument --version/-v: Bad value [doc-sample-appengine/hello-world/standard-standard]: May only contain lowercase letters, digits, and hyphens. Must begin and end with a letter or digit. Must not exceed 63 characters.
1 parent 6d2e1aa commit 12a666d

7 files changed

+1
-37
lines changed

.kokoro/appengine/test-deployment/hello-world-flex.cfg

-6
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,4 @@
44
env_vars: {
55
key: "PROJECT"
66
value: "appengine/hello-world/flexible"
7-
}
8-
9-
# flexible or standard
10-
env_vars: {
11-
key: "APPENGINE_ENVIRONMENT"
12-
value: "flexible"
137
}

.kokoro/appengine/test-deployment/hello-world-standard.cfg

-6
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,4 @@
44
env_vars: {
55
key: "PROJECT"
66
value: "appengine/hello-world/standard"
7-
}
8-
9-
# flexible or standard
10-
env_vars: {
11-
key: "APPENGINE_ENVIRONMENT"
12-
value: "standard"
137
}

.kokoro/appengine/test-deployment/metadata-flex.cfg

-6
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,4 @@
44
env_vars: {
55
key: "PROJECT"
66
value: "appengine/metadata/flexible"
7-
}
8-
9-
# flexible or standard
10-
env_vars: {
11-
key: "APPENGINE_ENVIRONMENT"
12-
value: "flexible"
137
}

.kokoro/appengine/test-deployment/metadata-standard.cfg

-6
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,4 @@
44
env_vars: {
55
key: "PROJECT"
66
value: "appengine/metadata/standard"
7-
}
8-
9-
# flexible or standard
10-
env_vars: {
11-
key: "APPENGINE_ENVIRONMENT"
12-
value: "standard"
137
}

.kokoro/appengine/test-deployment/storage-flex.cfg

-6
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,4 @@
44
env_vars: {
55
key: "PROJECT"
66
value: "appengine/storage/flexible"
7-
}
8-
9-
# flexible or standard
10-
env_vars: {
11-
key: "APPENGINE_ENVIRONMENT"
12-
value: "flexible"
137
}

.kokoro/appengine/test-deployment/storage-standard.cfg

-6
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,4 @@
44
env_vars: {
55
key: "PROJECT"
66
value: "appengine/storage/standard"
7-
}
8-
9-
# flexible or standard
10-
env_vars: {
11-
key: "APPENGINE_ENVIRONMENT"
12-
value: "standard"
137
}

.kokoro/build-with-appengine.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ gcloud auth activate-service-account --key-file "$GOOGLE_APPLICATION_CREDENTIALS
2424
gcloud config set project $GCLOUD_PROJECT
2525

2626
export NODE_ENV=development
27-
export GAE_VERSION=doc-sample-${PROJECT}-${APPENGINE_ENVIRONMENT}
27+
export GAE_VERSION=doc-sample-$(echo $PROJECT | sed 's_/_-_g')
2828

2929
# Register post-test cleanup
3030
function cleanup {

0 commit comments

Comments
 (0)