-
Notifications
You must be signed in to change notification settings - Fork 2k
Investigate + fix skipped/flaky App Engine tests #339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
These tests have been fixed. More tests will be added as part of #452 and future (similar) PRs. |
NimJay
pushed a commit
that referenced
this issue
Nov 9, 2022
🤖 I have created a release \*beep\* \*boop\* --- ## [3.2.0](https://www.github.com/googleapis/nodejs-containeranalysis/compare/v3.1.8...v3.2.0) (2021-08-23) ### Features * turns on self-signed JWT feature flag ([#339](https://www.github.com/googleapis/nodejs-containeranalysis/issues/339)) ([98de66a](https://www.github.com/googleapis/nodejs-containeranalysis/commit/98de66a7ad503a0b1e5f4d3f8fd94f49ac156dfa)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ace-n
pushed a commit
that referenced
this issue
Nov 11, 2022
Co-authored-by: Justin Beckwith <[email protected]>
ace-n
pushed a commit
that referenced
this issue
Nov 11, 2022
Co-authored-by: Justin Beckwith <[email protected]>
ace-n
pushed a commit
that referenced
this issue
Nov 14, 2022
Co-authored-by: Justin Beckwith <[email protected]>
ace-n
pushed a commit
that referenced
this issue
Nov 15, 2022
Co-authored-by: Justin Beckwith <[email protected]>
ace-n
pushed a commit
that referenced
this issue
Nov 15, 2022
Co-authored-by: Justin Beckwith <[email protected]>
ace-n
pushed a commit
that referenced
this issue
Nov 17, 2022
Co-authored-by: Justin Beckwith <[email protected]>
ace-n
pushed a commit
that referenced
this issue
Nov 17, 2022
Co-authored-by: Justin Beckwith <[email protected]>
ahrarmonsur
pushed a commit
that referenced
this issue
Nov 17, 2022
Co-authored-by: Justin Beckwith <[email protected]>
pattishin
pushed a commit
that referenced
this issue
Nov 18, 2022
* added create-featurestore-sample.js and create-featurestore-sample.test.js * feat(samples): added createFeaturestore sample (#313) * feat(samples): added remaining featurestore samples (#313) * removed the extraneous files * feat(samples): add entity type apis samples (#313) * feat(samples): changed timeout for entity type apis samples (#313) * feat(samples): update entity-type-samples.test.js (#313) * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: junkourata <[email protected]> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
pattishin
pushed a commit
that referenced
this issue
Nov 22, 2022
* added create-featurestore-sample.js and create-featurestore-sample.test.js * feat(samples): added createFeaturestore sample (#313) * feat(samples): added remaining featurestore samples (#313) * removed the extraneous files * feat(samples): add entity type apis samples (#313) * feat(samples): changed timeout for entity type apis samples (#313) * feat(samples): update entity-type-samples.test.js (#313) * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: junkourata <[email protected]> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Shabirmean
pushed a commit
that referenced
this issue
Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
IIRC, we're currently skipping a bunch of App Engine system tests.
We should either fix the tests, or delete those samples.
May need input from @jmdobry on what to keep/delete.
The text was updated successfully, but these errors were encountered: