Skip to content

healthcare API: FHIR resources cleanup and bug fixes #1850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 5, 2020

Conversation

noerog
Copy link
Contributor

@noerog noerog commented Jun 4, 2020

Fixes some bugs and does some cleanup.

Cleanup unrelated to bugs:

Remove fhir_resources.js file and move all methods to their own files that use the API client library (executeBundle, createResource, patchResource)
Update tests and README for new files created from fhir_resources.js
Use 'assert.strictEqual(new RegExp('').test(output), true);' syntax for tests
Use a new bundle.json file that's better formatted

Fixes:

b/157184695
b/157184092
b/157144932
b/157137180

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 4, 2020
@noerog noerog requested a review from fhinkel June 4, 2020 22:12
@fhinkel fhinkel added automerge Merge the pull request once unit tests and other checks pass. kokoro:run Add this label to force Kokoro to re-run the tests. labels Jun 5, 2020
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 5, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit 44949e4 into master Jun 5, 2020
@fhinkel fhinkel deleted the chc-fhir-fixes branch June 7, 2020 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants