Skip to content

ci: Add header checker #2999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 27, 2023
Merged

ci: Add header checker #2999

merged 2 commits into from
Jan 27, 2023

Conversation

kweinmeister
Copy link
Collaborator

@kweinmeister kweinmeister commented Jan 27, 2023

Adds the License Header bot configuration based on Google Cloud Node and Python Docs Samples.

Also, added a header to the workflow generation template, so new workflows are compliant. We can address adding missing headers as we go or in a separate PR.

@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: workflows Issues related to the Workflows API. labels Jan 27, 2023
@kweinmeister kweinmeister marked this pull request as ready for review January 27, 2023 18:16
@kweinmeister kweinmeister requested review from a team as code owners January 27, 2023 18:16
@grayside
Copy link
Collaborator

I'm assuming this check will not be marked required until we are in compliance.

Copy link
Contributor

@iennae iennae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kweinmeister
Copy link
Collaborator Author

I'm assuming this check will not be marked required until we are in compliance.

Sounds good @grayside. We can leave the check optional until it's passing consistently.

@kweinmeister kweinmeister merged commit 48d3517 into main Jan 27, 2023
@kweinmeister kweinmeister deleted the header-checker-lint branch January 27, 2023 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: workflows Issues related to the Workflows API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants