Skip to content

Update translate_batch_translate_text.js #3226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 20, 2023
Merged

Update translate_batch_translate_text.js #3226

merged 1 commit into from
May 20, 2023

Conversation

ivanmkc
Copy link
Contributor

@ivanmkc ivanmkc commented May 19, 2023

Recreates https://github.com/googleapis/nodejs-translate/pull/889/files

Addresses b/247881608

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@ivanmkc ivanmkc requested review from a team as code owners May 19, 2023 14:36
@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: translate Issues related to the Cloud Translation API. labels May 19, 2023
yil532
yil532 approved these changes May 19, 2023
View reviewed changes
Copy link
Contributor

@yil532 yil532 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

wend-lee
wend-lee approved these changes May 19, 2023
View reviewed changes
Copy link

@wend-lee wend-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

wend-lee
wend-lee approved these changes May 19, 2023
View reviewed changes
Copy link

@wend-lee wend-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pattishin
Copy link
Contributor

Hi @ivanmkc! Do you mind checking out the conventional commits check?

@kweinmeister kweinmeister merged commit f27018a into main May 20, 2023
@kweinmeister kweinmeister deleted the ivanmkc-patch-1 branch May 20, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pattishin pattishin pattishin approved these changes

@yil532 yil532 yil532 approved these changes

@wend-lee wend-lee wend-lee approved these changes

Assignees
No one assigned
Labels
api: translate Issues related to the Cloud Translation API. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ivanmkc @pattishin @yil532 @wend-lee @kweinmeister