chore: node 16 upgrade 🚧 [WIP]

.github/workflows/ci.yaml

@@ -28,7 +28,7 @@ jobs:
       - uses: actions/[email protected]
       - uses: actions/setup-node@v3
         with:
-          node-version: 14
+          node-version: 16
       - run: npm install
       - run: npm run lint
   docs:

.kokoro/common.cfg

@@ -12,12 +12,12 @@ build_file: "nodejs-docs-samples/.kokoro/trampoline.sh"
 # Configure the docker image for kokoro-trampoline.
 env_vars: {
     key: "TRAMPOLINE_IMAGE"
-    value: "gcr.io/cloud-devrel-kokoro-resources/node:14-user"
+    value: "gcr.io/cloud-devrel-kokoro-resources/node:16-user"
 }
 
 # Export XUnit test results for further analysis
 action {
     define_artifacts {
         regex: "**/*sponge_log.xml"
     }
-}
+}

.kokoro/functions/billing-periodic.cfg

@@ -15,7 +15,7 @@ env_vars: {
 # Configure the docker image for kokoro-trampoline.
 env_vars: {
     key: "TRAMPOLINE_IMAGE"
-    value: "gcr.io/cloud-devrel-kokoro-resources/node:14-user"
+    value: "gcr.io/cloud-devrel-kokoro-resources/node:16-user"
 }
 
 # Tell the trampoline which build file to use.

.kokoro/functions/imagemagick.cfg

@@ -9,7 +9,7 @@ env_vars: {
 # Configure the docker image for kokoro-trampoline.
 env_vars: {
     key: "TRAMPOLINE_IMAGE"
-    value: "gcr.io/cloud-devrel-kokoro-resources/node:14-user"
+    value: "gcr.io/cloud-devrel-kokoro-resources/node:16-user"
 }
 
 # Tell the trampoline which build file to use.

.kokoro/functions/ocr-app.cfg

@@ -9,7 +9,7 @@ env_vars: {
 # Configure the docker image for kokoro-trampoline.
 env_vars: {
     key: "TRAMPOLINE_IMAGE"
-    value: "gcr.io/cloud-devrel-kokoro-resources/node:14-user"
+    value: "gcr.io/cloud-devrel-kokoro-resources/node:16-user"
 }
 
 # Tell the trampoline which build file to use.

.kokoro/run/common.cfg

@@ -18,7 +18,7 @@ env_vars: {
 # Configure the docker image for kokoro-trampoline.
 env_vars: {
     key: "TRAMPOLINE_IMAGE"
-    value: "gcr.io/cloud-devrel-kokoro-resources/node:14-user"
+    value: "gcr.io/cloud-devrel-kokoro-resources/node:16-user"
 }
 
 # Export XUnit test results for further analysis

cloud-sql/mysql/mysql2/package.json

@@ -9,7 +9,7 @@
     "url": "https://github.com/GoogleCloudPlatform/nodejs-docs-samples.git"
   },
   "engines": {
-    "node": ">=14.0.0"
+    "node": ">=16.0.0"
   },
   "scripts": {
     "start": "node server/server.js",

cloud-tasks/snippets/package.json

@@ -5,7 +5,7 @@
   "author": "Google Inc.",
   "private": true,
   "engines": {
-    "node": ">=14.0.0"
+    "node": ">=16.0.0"
   },
   "files": [
     "*.js"

functions/imagemagick/test/index.test.js

@@ -1,4 +1,4 @@
-// Copyright 2017 Google LLC
+// Copyright 2023 Google LLC
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
@@ -80,45 +80,64 @@ describe('functions/imagemagick tests', () => {
       const PORT = 8080;
       const {ffProc, ffProcHandler} = await startFF(PORT);
 
-      await request({
-        url: `http://localhost:${PORT}/blurOffensiveImages`,
-        method: 'POST',
-        data: {
+      try {
+        await request({
+          url: `http://localhost:${PORT}/blurOffensiveImages`,
+          method: 'POST',
           data: {
-            bucket: BUCKET_NAME,
-            name: testFiles.safe,
+            data: {
+              bucket: BUCKET_NAME,
+              name: testFiles.safe,
+            },
           },
-        },
-      });
+        });
+      } catch(error) {
+        assert.fail(error);
+      }
+
       ffProc.kill();
-      const stdout = await ffProcHandler;
-      assert.ok(stdout.includes(`Detected ${testFiles.safe} as OK.`));
+
+      try {
+        const stdout = await ffProcHandler;
+        assert.ok(stdout.includes(`Detected ${testFiles.safe} as OK.`));
+      } catch(error) {
+        assert.fail(error);
+      }
     });
 
     it('blurOffensiveImages successfully blurs offensive images', async () => {
       const PORT = 8081;
       const {ffProc, ffProcHandler} = await startFF(PORT);
 
-      await request({
-        url: `http://localhost:${PORT}/blurOffensiveImages`,
-        method: 'POST',
-        data: {
+      try {
+        await request({
+          url: `http://localhost:${PORT}/blurOffensiveImages`,
+          method: 'POST',
           data: {
-            bucket: BUCKET_NAME,
-            name: testFiles.offensive,
+            data: {
+              bucket: BUCKET_NAME,
+              name: testFiles.offensive,
+            },
           },
-        },
-      });
+        });
+      } catch(error) {
+        assert.fail(error);
+      }
 
       ffProc.kill();
-      const stdout = await ffProcHandler;
-
-      assert.ok(stdout.includes(`Blurred image: ${testFiles.offensive}`));
-      assert.ok(
-        stdout.includes(
-          `Uploaded blurred image to: gs://${BLURRED_BUCKET_NAME}/${testFiles.offensive}`
-        )
-      );
+
+      try {
+        const stdout = await ffProcHandler;
+
+        assert.ok(stdout.includes(`Blurred image: ${testFiles.offensive}`));
+        assert.ok(
+          stdout.includes(
+            `Uploaded blurred image to: gs://${BLURRED_BUCKET_NAME}/${testFiles.offensive}`
+          )
+        );
+      } catch(error) {
+        assert.fail(error);
+      }
 
       const exists = await storage
         .bucket(BLURRED_BUCKET_NAME)
@@ -132,20 +151,29 @@ describe('functions/imagemagick tests', () => {
       const {ffProc, ffProcHandler} = await startFF(PORT);
       const missingFileName = 'file-does-not-exist.jpg';
 
-      await request({
-        url: `http://localhost:${PORT}/blurOffensiveImages`,
-        method: 'POST',
-        data: {
+      try {
+        await request({
+          url: `http://localhost:${PORT}/blurOffensiveImages`,
+          method: 'POST',
           data: {
-            bucket: BUCKET_NAME,
-            name: missingFileName,
+            data: {
+              bucket: BUCKET_NAME,
+              name: missingFileName,
+            },
           },
-        },
-      });
+        });
+      } catch(error) {
+        assert.fail(error);
+      }
 
       ffProc.kill();
-      const stdout = await ffProcHandler;
-      assert.ok(stdout.includes(`Detected ${missingFileName} as OK.`));
+
+      try {
+        const stdout = await ffProcHandler;
+        assert.ok(stdout.includes(`Detected ${missingFileName} as OK.`));
+      } catch(error) {
+        assert.fail(error);
+      }
     });
   });
 

package.json

@@ -4,7 +4,7 @@
   "license": "Apache-2.0",
   "author": "Google Inc.",
   "engines": {
-    "node": ">=14.0.0"
+    "node": ">=16.0.0"
   },
   "repository": {
     "type": "git",

renovate.json

@@ -7,7 +7,7 @@
   "rebaseStalePrs": false,
   "force": {
     "constraints": {
-      "node": "< 15.0.0"
+      "node": ">= 16.0.0"
     }
   }
 }

run/idp-sql/Dockerfile

@@ -4,7 +4,7 @@
 
 # Use the official lightweight Node.js image.
 # https://hub.docker.com/_/node
-FROM node:14-slim
+FROM node:16-slim
 
 # Create and change to the app directory.
 WORKDIR /usr/src/app

run/idp-sql/package.json

@@ -10,7 +10,7 @@
     "url": "https://github.com/GoogleCloudPlatform/nodejs-docs-samples.git"
   },
   "engines": {
-    "node": ">=12.0.0"
+    "node": ">=16.0.0"
   },
   "scripts": {
     "start": "node index.js",

run/websockets/package.json

@@ -5,6 +5,9 @@
   "private": true,
   "license": "Apache Version 2.0",
   "author": "Google LLC",
+  "engines": {
+    "node": ">=16.x.x"
+  },
   "scripts": {
     "start": "node index.js",
     "test": "echo \"Error: no test specified\" && exit 0",

workflows/invoke-private-endpoint/package.json

@@ -10,7 +10,7 @@
     "url": "https://github.com/GoogleCloudPlatform/nodejs-docs-samples.git"
   },
   "engines": {
-    "node": ">=14.0.0"
+    "node": ">=16.0.0"
   },
   "scripts": {
     "start": "node app.js",

workflows/package.json

@@ -4,7 +4,7 @@
   "license": "Apache-2.0",
   "author": "Google LLC",
   "engines": {
-    "node": ">=12.0.0"
+    "node": ">=16.0.0"
   },
   "scripts": {
     "build": "tsc -p .",