Skip to content

refactor: update [email protected] to latest on github v4.0.1 #3324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 5, 2023

Conversation

pattishin
Copy link
Contributor

@pattishin pattishin commented Jul 5, 2023

Description

Issue:

To unblock prettier update to v3 #3322.
ci/lint workflow using [email protected] as repo is still on [email protected]. Upgraded to latest [email protected].

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jul 5, 2023
@pattishin pattishin marked this pull request as ready for review July 5, 2023 17:55
@pattishin pattishin requested a review from a team as a code owner July 5, 2023 17:55
@kweinmeister kweinmeister added the automerge Merge the pull request once unit tests and other checks pass. label Jul 5, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit b9ef7e9 into main Jul 5, 2023
@gcf-merge-on-green gcf-merge-on-green bot deleted the refactor/update-gts branch July 5, 2023 19:14
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants