chore(cleanup): retire media translate samples #3325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
samples
pattishin
requested changes
Jul 5, 2023
minherz
force-pushed
the
minherz/remove-media-translate-samples
branch
from
014c1a9 to
b1fe59f
Compare
add README with the deprecation message. remove tests.
minherz
force-pushed
the
minherz/remove-media-translate-samples
branch
from
b1fe59f to
006c191
Compare
The test(s) are disabled to avoid false positives and to reduce maintenance burden. Deleting tests only is possible but it provides small benefits because we have to keep code samples until API is fully deprecated in one year (July 1, 2024). We should be able to delete the folder after that. Does it address your concern? |
pattishin
approved these changes
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds README with the deprecation message.
Removes tests.
Fixes #3323