Skip to content

chore: adding in region tag for cloud storage v2 unit test docs #3404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 8, 2023
Merged

chore: adding in region tag for cloud storage v2 unit test docs #3404

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3f2a7fc
refactor: adding in region tag to link back to cloud storage v2 unit …
pattishin Aug 8, 2023
119a46c
Merge branch 'main' into refactor/b-293285977
pattishin Aug 8, 2023
b9cd842
chore: space clean up
pattishin Aug 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions functions/v2/helloGCS/test/unit.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@
// See the License for the specific language governing permissions and
// limitations under the License.

// [START functions_cloudevent_storage_unit_test]

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: consider removing extra lines 16 and 57, this will add spaces in the docs. Approving either way.

const {getFunction} = require('@google-cloud/functions-framework/testing');

describe('functions_cloudevent_storage', () => {
Expand Down Expand Up @@ -52,3 +54,5 @@ describe('functions_cloudevent_storage', () => {
assert(console.log.calledWith('File: my-file.txt'));
});
});

// [END functions_cloudevent_storage_unit_test]