-
Notifications
You must be signed in to change notification settings - Fork 2k
Add Cloud Functions ImageMagick sample. #361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b7a33d3
to
8f3541b
Compare
8f3541b
to
b0b0cb8
Compare
Codecov Report
@@ Coverage Diff @@
## master #361 +/- ##
=======================================
Coverage 83.88% 83.88%
=======================================
Files 4 4
Lines 422 422
=======================================
Hits 354 354
Misses 68 68 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - comments are the questions/possible improvements I had in mind.
* Replace `YOUR_BUCKET_NAME` with the name of your image Cloud Storage Bucket. | ||
* Replace `YOUR_STAGE_BUCKET_NAME` with the name of your Cloud Storage Bucket. | ||
|
||
1. Upload an offensive image to your image Storage bucket, such as this image of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NSFW warning? 😛
@@ -0,0 +1,105 @@ | |||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thought: do we want to add any system tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The functions samples are all unit tests for now.
No description provided.