-
Notifications
You must be signed in to change notification settings - Fork 2k
ci(scheduler): migrate to new CI #4006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @glasnt, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request migrates the Cloud Scheduler samples to a new CI (Continuous Integration) system. The changes involve updating the CI configuration files and modifying the createJob.js
sample to use ES modules instead of CommonJS modules. Specifically, the scheduler sample is removed from the production CI configuration and added to the development CI configuration. The createJob.js
file is updated to use import
instead of require
for importing the CloudSchedulerClient.
Highlights
- CI Configuration Update: The pull request updates the CI configuration files (
nodejs-dev.jsonc
andnodejs-prod.jsonc
) to reflect the new CI setup. The scheduler sample is moved from the production to the development CI configuration. - Module Migration: The
createJob.js
sample is updated to use ES modules (import
) instead of CommonJS modules (require
).
Changelog
- .github/config/nodejs-dev.jsonc
- Added 'scheduler' to the list of samples in the development CI configuration.
- .github/config/nodejs-prod.jsonc
- Removed 'scheduler' from the list of samples in the production CI configuration.
- scheduler/createJob.js
- Replaced
'use strict';
with an empty line. - Replaced
const {CloudSchedulerClient} = require('@google-cloud/scheduler');
withimport { CloudSchedulerClient } from '@google-cloud/scheduler';
. - Removed some extra blank lines to improve readability.
- Replaced
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
The CI pipeline, a watchful eye,
Ensuring our code reaches for the sky.
From commit to deploy,
It helps us enjoy,
A smoother, more reliable supply.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
Warning Gemini encountered an error creating the review. You can try again by commenting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Fixes #
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
npm test
(see Testing)npm run lint
(see Style)GoogleCloudPlatform/nodejs-docs-samples
. Not a fork.