Adds backoff / retry to HTTP calls. #545

gguuss · 2018-01-05T01:35:13Z

No description provided.

codecov · 2018-01-05T01:44:19Z

Codecov Report

Merging #545 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #545   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines           3      3           
=====================================
  Hits            3      3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cb34c0...be80033. Read the comment docs.

ace-n · 2018-01-05T18:35:13Z

iot/http_example/package.json

    "jsonwebtoken": "7.4.1",
-    "request": "2.82.0",
-    "uuid": "3.1.0"
+    "requestretry": "requestretry",


Should this be a SemVer number? e.g. 1.12.2, the latest version of the library.

ace-n · 2018-01-05T18:37:08Z

iot/http_example/cloudiot_http_example.js

@@ -182,6 +201,21 @@ function publishAsync (authToken, messageCount, numMessages) {
 // [START iot_http_getconfig]
 function getConfig (authToken, version) {
  console.log(`Getting config from URL: ${urlBase}`);
+
+  // Custom backoff functions
+  function retryNotSuccess (err, response, body) {


Is there a library that comes with these built-in? (Perhaps nodejs-repo-tools?)

Done, switched to recommended library that uses built-in exponential backoff.

ace-n · 2018-01-05T18:37:52Z

iot/http_example/cloudiot_http_example.js

@@ -141,16 +141,35 @@ function publishAsync (authToken, messageCount, numMessages) {
      binary_data: binaryData
    }
  };
+
+  // Custom backoff functions
+  function retryNotSuccess (err, response, body) {


Ditto to below comment - can these come from a library?

Done, switched to recommended library that uses built-in exponential backoff.

…latform/nodejs-docs-samples into exponential-backoff

ace-n

LGTM once nits are fixed. 👍

ace-n · 2018-01-05T22:15:37Z

iot/http_example/cloudiot_http_example.js

  };

  // Send events for high-frequency updates, update state only occasionally.
  const delayMs = argv.messageType === 'events' ? 1000 : 2000;
-  request.post(options, function (error, response, body) {
+  console.log(JSON.stringify(request));


Is this intended?

ace-n · 2018-01-05T22:16:55Z

iot/http_example/cloudiot_http_example.js

@@ -17,7 +17,7 @@
 // [START iot_http_includes]
 const fs = require('fs');
 const jwt = require('jsonwebtoken');
-const request = require('requestretry');
+const request = require('retry-request');


Nit: can we name this something other than request (to avoid confusion with the library of the same name)? Maybe retryRequest?

ace-n · 2018-01-05T22:19:36Z

iot/http_example/cloudiot_http_example.js

+      function (incomingHttpMessage) {
+        console.log('Retry?');
+        return incomingHttpMessage.statusMessage !== 'OK';
+      }
  };
  console.log(JSON.stringify(request.RetryStrategies));


Ditto - is this intended?

ace-n · 2018-01-05T22:19:51Z

iot/http_example/cloudiot_http_example.js

  };
  console.log(JSON.stringify(request.RetryStrategies));
-  request.get(options, function (error, response, body) {
+  request(options, function (error, response, body) {


Nit: arrow function?

(Apply this comment throughout your PR if you decide to make any changes.)

🤖 I have created a release \*beep\* \*boop\* --- ### [2.3.4](https://www.github.com/googleapis/nodejs-tasks/compare/v2.3.3...v2.3.4) (2021-06-30) ### Bug Fixes * **deps:** google-gax v2.17.0 with mTLS ([#543](https://www.github.com/googleapis/nodejs-tasks/issues/543)) ([d1a715d](https://www.github.com/googleapis/nodejs-tasks/commit/d1a715d92e0136b1840798c2e122e165201715cd)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

Adds backoff / retry to HTTP calls.

cf1da6a

Merge branch 'master' into exponential-backoff

3183147

ace-n suggested changes Jan 5, 2018

View reviewed changes

gguuss added 2 commits January 5, 2018 12:18

Switches request library from requestretry to retry-request.

d3a9fb8

Merge branch 'exponential-backoff' of https://github.com/GoogleCloudP…

be80033

…latform/nodejs-docs-samples into exponential-backoff

ace-n approved these changes Jan 5, 2018

View reviewed changes

ace-n reviewed Jan 5, 2018

View reviewed changes

gguuss merged commit fbb2f8a into master Jan 9, 2018

gguuss deleted the exponential-backoff branch February 26, 2018 19:13

snyk-bot mentioned this pull request Sep 5, 2020

[Snyk] Security upgrade twilio from 2.11.1 to 3.41.0 ninadhatkar/nodejs-docs-samples#35

Open

snyk-bot mentioned this pull request Apr 7, 2022

[Snyk] Security upgrade twilio from 2.11.1 to 3.41.0 ninadhatkar/nodejs-docs-samples#188

Open

grayside mentioned this pull request Oct 26, 2022

migrate code from googleapis/nodejs-tasks #2792

Merged

ace-n pushed a commit that referenced this pull request Nov 16, 2022

chore: release 3.3.2 (#545)

8752269

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

ace-n mentioned this pull request Nov 16, 2022

migrate code from googleapis/nodejs-video-intelligence #2855

Merged

ace-n pushed a commit that referenced this pull request Nov 17, 2022

chore: release 3.3.2 (#545)

d4db78a

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

ace-n pushed a commit that referenced this pull request Nov 17, 2022

chore(deps): update dependency mocha to v8 (#545)

4615f83

ace-n mentioned this pull request Nov 17, 2022

migrate code from googleapis/nodejs-translate #2862

Merged

ace-n pushed a commit that referenced this pull request Nov 17, 2022

chore(deps): update dependency mocha to v8 (#545)

2f354a6

ahrarmonsur pushed a commit that referenced this pull request Nov 17, 2022

chore: release 3.3.2 (#545)

8f9c120

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

ace-n pushed a commit that referenced this pull request Nov 17, 2022

chore(deps): update dependency mocha to v8 (#545)

c492c14

ace-n pushed a commit that referenced this pull request Nov 17, 2022

chore(deps): update dependency mocha to v8 (#545)

c2d68c5

ace-n pushed a commit that referenced this pull request Nov 17, 2022

chore(deps): update dependency mocha to v8 (#545)

81fb6a0

ninadhatkar mentioned this pull request Nov 28, 2023

[Snyk] Security upgrade twilio from 2.11.1 to 3.41.0 ninadhatkar/nodejs-docs-samples#351

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds backoff / retry to HTTP calls. #545

Adds backoff / retry to HTTP calls. #545

gguuss commented Jan 5, 2018

codecov bot commented Jan 5, 2018 •

edited

Loading

ace-n Jan 5, 2018

gguuss Jan 5, 2018

ace-n Jan 5, 2018

gguuss Jan 5, 2018

ace-n Jan 5, 2018

gguuss Jan 5, 2018

ace-n left a comment

ace-n Jan 5, 2018

ace-n Jan 5, 2018

ace-n Jan 5, 2018

ace-n Jan 5, 2018 •

edited

Loading

Adds backoff / retry to HTTP calls. #545

Adds backoff / retry to HTTP calls. #545

Conversation

gguuss commented Jan 5, 2018

codecov bot commented Jan 5, 2018 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ace-n left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ace-n Jan 5, 2018 • edited Loading

Choose a reason for hiding this comment

codecov bot commented Jan 5, 2018 •

edited

Loading

ace-n Jan 5, 2018 •

edited

Loading