Update snapshot tests and pin upstream versions #254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
punya
approved these changes
Jun 13, 2023
DouglasHeriot
added a commit
to DouglasHeriot/opentelemetry-operations-python
that referenced
this pull request
Aug 3, 2023
Fix in GoogleCloudPlatform#254 didn't apply to tox environments that run `pip install .` `test_detects_gce` was failing with opentelemetry-sdk version 1.19.0 instead of 1.18.0
DouglasHeriot
added a commit
to DouglasHeriot/opentelemetry-operations-python
that referenced
this pull request
Aug 3, 2023
Fix in GoogleCloudPlatform#254 didn't apply to tox environments that run `pip install .` `test_detects_gce` was failing with opentelemetry-sdk version 1.19.0 instead of 1.18.0
aabmass
added a commit
that referenced
this pull request
Aug 3, 2023
Fix in #254 didn't apply to tox environments that run `pip install .` `test_detects_gce` was failing with opentelemetry-sdk version 1.19.0 instead of 1.18.0 Co-authored-by: Aaron Abbott <[email protected]>
aabmass
added a commit
that referenced
this pull request
Aug 3, 2023
* Pin upstream version of opentelemetry when running tests Fix in #254 didn't apply to tox environments that run `pip install .` `test_detects_gce` was failing with opentelemetry-sdk version 1.19.0 instead of 1.18.0 * Don't use `pkg_resources.get_distribution(..).version` Similar to discussion at googleapis/python-api-core#27 I am using opentelemetry in an environment where modules are vendored without pip. So, pkg_resources can not be used to search for a module at runtime to get its version. --------- Co-authored-by: Aaron Abbott <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pinning the version should prevent the user agent strings from breaking every tiem a new release is made. The pinned version should be regularly bumped (dependabot or renovate would work nice here).