Skip to content

Build failed in video/cloud-client/analyze with "The bucket you tried to delete was not empty". #4354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tmatsuo opened this issue Jul 22, 2020 · 3 comments · Fixed by #4361
Closed

Build failed in video/cloud-client/analyze with "The bucket you tried to delete was not empty". #4354

tmatsuo opened this issue Jul 22, 2020 · 3 comments · Fixed by #4361
Assignees
@tmatsuo
Labels
api: videointelligence Issues related to the Video Intelligence API API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@tmatsuo
Copy link
Contributor

tmatsuo commented Jul 22, 2020

Build

Log:

Traceback (most recent call last):
  File "/workspace/video/cloud-client/analyze/beta_snippets_test.py", line 63, in bucket
    bucket.delete(force=True)
  File "/workspace/video/cloud-client/analyze/.nox/py-3-7/lib/python3.7/site-packages/google/cloud/storage/bucket.py", line 1360, in delete
    timeout=timeout,
  File "/workspace/video/cloud-client/analyze/.nox/py-3-7/lib/python3.7/site-packages/google/cloud/_http.py", line 423, in api_request
    raise exceptions.from_http_response(response)
google.api_core.exceptions.Conflict: 409 DELETE https://storage.googleapis.com/storage/v1/b/tmp-8630953c5a584758ad851603d4dc1823: The bucket you tried to delete was not empty.

This should be an easy fix with something like force=True.
@tmatsuo tmatsuo self-assigned this Jul 22, 2020
@tmatsuo
Copy link
Contributor Author

tmatsuo commented Jul 22, 2020

Oops, the code already uses force=True. I'll take a deeper look.

@tmatsuo tmatsuo added api: videointelligence Issues related to the Video Intelligence API API. buildcop: flaky priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Jul 22, 2020
@tmatsuo
Copy link
Contributor Author

tmatsuo commented Jul 22, 2020

The test is using uuid4 for the bucket name, so it is unlikely that another build was using the same bucket. I think it's more likely a bug in the client library.

@tmatsuo
Copy link
Contributor Author

tmatsuo commented Jul 22, 2020

Maybe we can just retry harder upon 409 errors.

tmatsuo pushed a commit to tmatsuo/python-docs-samples that referenced this issue Jul 22, 2020
testing(videointelligence): retry harder upon 409s
dbec7a2 
fixes GoogleCloudPlatform#4354
@tmatsuo tmatsuo mentioned this issue Jul 22, 2020
Merged
engelke pushed a commit that referenced this issue Jul 23, 2020
testing(videointelligence): retry harder upon 409s (#4361)
8738b67 
fixes #4354
dizcology pushed a commit that referenced this issue Sep 11, 2023
@danoscarmike
testing(videointelligence): retry harder upon 409s [(#4361)](#4361)
5864c70 
fixes #4354
leahecole pushed a commit that referenced this issue Sep 15, 2023
@leahecole
testing(videointelligence): retry harder upon 409s [(#4361)](#4361)
928b57e 
fixes #4354
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmatsuo tmatsuo

Labels
api: videointelligence Issues related to the Video Intelligence API API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

testing(videointelligence): retry harder upon 409s tmatsuo/python-docs-samples
1 participant
@tmatsuo