Skip to content

Ignore Flake8 import order error I202 to accommodate region tags #1209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 9, 2017
Merged

Ignore Flake8 import order error I202 to accommodate region tags #1209

merged 4 commits into from
Nov 9, 2017

Conversation

andrewsg
Copy link
Member

@andrewsg andrewsg commented Nov 9, 2017

No description provided.

@andrewsg andrewsg requested a review from theacodes November 9, 2017 18:09
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 9, 2017
@andrewsg
Copy link
Member Author

andrewsg commented Nov 9, 2017

I decided to tell Flake to ignore this error because some of the detections were due to region tags inside import blocks, which is not an error given our use case. We could alternatively put # ignores inside each file where the region tags occur inside an import block; what do you think?

@andrewsg andrewsg merged commit 01fc1d5 into GoogleCloudPlatform:master Nov 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theacodes theacodes theacodes approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewsg @theacodes @googlebot