-
Notifications
You must be signed in to change notification settings - Fork 6.5k
feat: add code samples for model optimizer #13297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @yan283, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request adds a new code sample, text_example02.py
, demonstrating how to use the Vertex AI API with the model optimizer feature. The sample generates text from a given input, specifically tailored for optimizing model costs. The code initializes the Vertex AI client, specifies a model with cost optimization preferences, and then generates content based on a prompt about flower shop names.
Highlights
- New Code Sample: Introduces
text_example02.py
to showcase the model optimizer feature within Vertex AI. - Model Optimizer: Demonstrates how to configure a GenerativeModel to prioritize cost using
feature_selection_preference=GenerationConfig.ModelConfig.FeatureSelectionPreference.PRIORITIZE_COST
. - Text Generation: Provides an example of generating text content using the Vertex AI API with a specific prompt.
Changelog
- generative_ai/text_generation/text_example02.py
- Added a new file
text_example02.py
containing a code sample for using the Vertex AI model optimizer. - The sample initializes Vertex AI with a project ID and location.
- It configures a GenerativeModel to prioritize cost during text generation.
- The sample generates content based on a prompt asking for flower shop name ideas.
- The generated text is printed to the console as an example response.
- Added a new file
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
A model's mind,
Optimized for cost's confine,
Generates with care.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The code introduces a new example for using the model optimizer with Vertex AI. The example is clear and concise, demonstrating how to set the feature_selection_preference
to PRIORITIZE_COST
. Overall, the code is well-structured and easy to understand.
Summary of Findings
- TODO Comment: The
TODO
comment on line 24 should be addressed by updating and uncommenting the line with the project ID.
Merge Readiness
The code is well-structured and the example is clear. However, the TODO
comment should be addressed before merging. I am unable to directly approve the pull request, and recommend that others review and approve this code before merging.
UPDATE: Not all features work with the Gen AI SDK yet, so we're keeping this PR open. |
Add a code sample for model-optimizer using Vertex AI API
Checklist
nox -s py-3.9
(see Test Environment Setup)nox -s lint
(see Test Environment Setup)