Skip to content

BigQuery: Removes unused API samples #1459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 18, 2018

Conversation

alixhami
Copy link
Contributor

Removes API samples, which are no longer used on devsite.

@alixhami alixhami requested a review from tswast April 18, 2018 00:08
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 18, 2018
@@ -1 +0,0 @@
Gandalf,2000,140.0,1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to double-check that none of the cloud-client sample tests use these test data files.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The snippets tests are passing and I didn't see any usage of data files, which prompted me to also delete the unused cloud-client data files.

@tswast tswast merged commit 19f7f65 into GoogleCloudPlatform:master Apr 18, 2018
@alixhami alixhami deleted the bq-delete-api-samples branch April 24, 2018 17:50
plamut pushed a commit to plamut/python-bigquery that referenced this pull request Jun 25, 2020
…latform/python-docs-samples#1459)

* BigQuery: Removes unused API samples

* removes unused sample data files
plamut pushed a commit to plamut/python-bigquery that referenced this pull request Jul 22, 2020
…latform/python-docs-samples#1459)

* BigQuery: Removes unused API samples

* removes unused sample data files
shollyman pushed a commit to googleapis/python-bigquery that referenced this pull request Jul 22, 2020
…thon-docs-samples#1459)

* BigQuery: Removes unused API samples

* removes unused sample data files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bigquery cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants