Skip to content

Remove leftover merge conflict. #1657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 27, 2018
Merged

Remove leftover merge conflict. #1657

merged 1 commit into from
Aug 27, 2018

Conversation

kurtisvg
Copy link
Contributor

Removing the leftover merge conflict that's tripping DPEbot up.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 27, 2018
@kurtisvg kurtisvg added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Aug 27, 2018
@kurtisvg kurtisvg requested review from tswast and frankyn August 27, 2018 18:14
<<<<<<< HEAD
google-cloud-storage==1.8.0
google-cloud-pubsub==0.33.0
=======
google-cloud-storage==1.10.0
google-cloud-pubsub==0.32.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like pubsub went back a minor version is this expected?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure - I'm hoping that fixing this file will unblock DPEbot and it'll autoupdate it with everything else.

Copy link
Contributor

@frankyn frankyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to figure out if it helps DPE bot to auto-update.

@kurtisvg kurtisvg merged commit 00435d2 into master Aug 27, 2018
@kurtisvg kurtisvg deleted the req-fix branch August 27, 2018 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants