-
Notifications
You must be signed in to change notification settings - Fork 6.5k
IAM: added snippet for remove member #2165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
1828152
added remove member sample
DSdatsme f3841e2
WPI test cases
DSdatsme cb6a663
Add IAM remove user snippet
DSdatsme b6fe450
[IAM] test case to add/remove member
DSdatsme 03feaf9
[IAM] fixed test errors for add/remove member
DSdatsme 650f9fa
Fixes tests
gguuss File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,17 +13,43 @@ | |
# limitations under the License. | ||
|
||
import os | ||
import random | ||
|
||
import access | ||
import service_accounts | ||
|
||
|
||
def test_access(capsys): | ||
project = os.environ['GCLOUD_PROJECT'] | ||
# Setting up variables for testing | ||
project_id = os.environ['GCLOUD_PROJECT'] | ||
|
||
policy = access.get_policy(project) | ||
# specifying a sample role to be assigned | ||
gcp_role = 'roles/owner' | ||
|
||
# section to create service account to test policy updates. | ||
rand = str(random.randint(0, 1000)) | ||
name = 'python-test-' + rand | ||
email = name + '@' + project_id + '.iam.gserviceaccount.com' | ||
member = 'serviceAccount:' + email | ||
service_accounts.create_service_account( | ||
project_id, name, 'Py Test Account') | ||
|
||
policy = access.get_policy(project_id) | ||
out, _ = capsys.readouterr() | ||
assert 'etag' in out | ||
|
||
policy = access.modify_policy_add_role(policy, gcp_role, member) | ||
out, _ = capsys.readouterr() | ||
assert 'etag' in out | ||
|
||
policy = access.set_policy(project, policy) | ||
policy = access.modify_policy_remove_member(policy, gcp_role, member) | ||
out, _ = capsys.readouterr() | ||
assert 'etag' in out | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm seeing this test failing in Python 2. |
||
|
||
policy = access.set_policy(project_id, policy) | ||
out, _ = capsys.readouterr() | ||
assert 'etag' in out | ||
|
||
# deleting the service account created above | ||
service_accounts.delete_service_account( | ||
email) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.