Skip to content

Update list blobs to use new client.list_blobs() method. #2296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 24, 2019
Merged

Update list blobs to use new client.list_blobs() method. #2296

merged 5 commits into from
Jul 24, 2019

Conversation

frankyn
Copy link
Contributor

@frankyn frankyn commented Jul 24, 2019 •
edited
Loading

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 24, 2019
@frankyn frankyn added do not merge Indicates a pull request not ready for merge, due to either quality or timing. In Progress labels Jul 24, 2019
@frankyn frankyn removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 24, 2019
@frankyn frankyn requested a review from tswast July 24, 2019 20:34
@gguuss
Copy link
Contributor

gguuss commented Jul 24, 2019 •
edited
Loading

PTAL at the fix in this PR - #2281

After merging, your tests should pass and Travis should be happy.

tswast
tswast approved these changes Jul 24, 2019
View reviewed changes
Copy link
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Frank.

@frankyn frankyn merged commit 03280fa into master Jul 24, 2019
@gguuss gguuss deleted the update-list-blobs branch July 24, 2019 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@frankyn @gguuss @tswast @googlebot