Skip to content

Adjust Cloud Firestore update_doc_array snippet to not require an extra import #2306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jlara310
Copy link
Member

Some readers were tripping over how to resolve the import of ArrayUnion and ArrayRemove, see:

googleapis/google-cloud-python#8792
https://stackoverflow.com/questions/57219705/unable-to-import-fieldvalue-arrayunion/57226431#57226431

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 29, 2019
@jlara310 jlara310 marked this pull request as ready for review July 29, 2019 22:42
@jlara310 jlara310 changed the title Adjust update_doc_array snippet to not require an extra import Adjust Cloud Firestore update_doc_array snippet to not require an extra import Jul 29, 2019
Copy link
Contributor

@BenWhitehead BenWhitehead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good and make the array operations use the same pattern as SERVER_TIMESTAMP.

@BenWhitehead BenWhitehead merged commit c9337cd into GoogleCloudPlatform:master Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants