fix: Reuse HMAC key as we have a limit of 5 #3037
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
frankyn
suggested changes
Mar 5, 2020
| @@ -35,8 +36,7 @@ | |||
| SERVICE_ACCOUNT_EMAIL = os.environ["HMAC_KEY_TEST_SERVICE_ACCOUNT"] | |||
| STORAGE_CLIENT = storage.Client(project=PROJECT_ID) | |||
|
|
|||
|
|
|||
| @pytest.fixture | |||
| @pytest.fixture(scope="module") | |||
There was a problem hiding this comment.
Does this correct the fixture once for the entire test suite? If test_delete_key is ran first then it would be deleted for all.
There was a problem hiding this comment.
With the way we have things configured, within the module these will run in order. Yes, if delete is run first, the key will be gone for our tests. So this change makes the order significant.
…n-docs-samples into reuse-hmac-key
|
Python 2.7 Failure isn't HMAC 👍 |
frankyn
approved these changes
Mar 5, 2020
busunkim96
approved these changes
Mar 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are limited to a low number (5) hmac keys for a single project. To avoid exhausting this under test this will reuse that key and depend on the test order (a bit) to keep our count down. Fixes #2822